From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6273C433E0 for ; Mon, 25 Jan 2021 18:00:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70E9122583 for ; Mon, 25 Jan 2021 18:00:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731250AbhAYSAF (ORCPT ); Mon, 25 Jan 2021 13:00:05 -0500 Received: from verein.lst.de ([213.95.11.211]:45049 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729837AbhAYR4W (ORCPT ); Mon, 25 Jan 2021 12:56:22 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 1DB9C68B02; Mon, 25 Jan 2021 18:55:29 +0100 (CET) Date: Mon, 25 Jan 2021 18:55:28 +0100 From: Christoph Hellwig To: Jens Axboe Cc: Christoph Hellwig , Tejun Heo , Coly Li , Song Liu , device-mapper development , linux-bcache , "open list:SOFTWARE RAID (Multiple Disks) SUPPORT" , linux-s390 , linux-block Subject: Re: [PATCH 05/10] block: do not reassig ->bi_bdev when partition remapping Message-ID: <20210125175528.GA13451@lst.de> References: <20210124100241.1167849-1-hch@lst.de> <20210124100241.1167849-6-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org On Mon, Jan 25, 2021 at 10:53:36AM -0700, Jens Axboe wrote: > On Sun, Jan 24, 2021 at 3:05 AM Christoph Hellwig wrote: > > > > There is no good reason to reassign ->bi_bdev when remapping the > > partition-relative block number to the device wide one, as all the > > information required by the drivers comes from the gendisk anyway. > > > > Keeping the original ->bi_bdev alive will allow to greatly simplify > > the partition-away I/O accounting. > > This one causes boot failures for me on my laptop... Any output to share? Details of the config?