From: Christoph Hellwig <hch@infradead.org>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-bcache@vger.kernel.org,
linux-nvdimm@lists.01.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2] include: Remove pagemap.h from blkdev.h
Date: Wed, 10 Mar 2021 08:43:21 +0000 [thread overview]
Message-ID: <20210310084321.GA682482@infradead.org> (raw)
In-Reply-To: <20210309195747.283796-1-willy@infradead.org>
On Tue, Mar 09, 2021 at 07:57:47PM +0000, Matthew Wilcox (Oracle) wrote:
> My UEK-derived config has 1030 files depending on pagemap.h before
> this change. Afterwards, just 326 files need to be rebuilt when I
> touch pagemap.h. I think blkdev.h is probably included too widely,
> but untangling that dependency is harder and this solves my problem.
> x86 allmodconfig builds, but there may be implicit include problems
> on other architectures.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---
> v2: Fix CONFIG_SWAP=n implicit use of pagemap.h by swap.h. Increases
> the number of files from 240, but that's still a big win -- 68%
> reduction instead of 77%.
Looks good. I suspect blkdev.h also has penty of other includes that
aren't needed either..
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2021-03-10 8:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 19:57 [PATCH v2] include: Remove pagemap.h from blkdev.h Matthew Wilcox (Oracle)
2021-03-09 20:47 ` Dan Williams
2021-03-09 20:50 ` Jens Axboe
2021-03-10 8:43 ` Christoph Hellwig [this message]
2021-03-10 10:29 ` Coly Li
2021-03-10 14:51 ` Martin K. Petersen
2021-03-10 18:28 ` William Kucharski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210310084321.GA682482@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-scsi@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).