From: Zheng Yongjun <zhengyongjun3@huawei.com> To: <colyli@suse.de>, <kent.overstreet@gmail.com>, <linux-bcache@vger.kernel.org>, <linux-kernel@vger.kernel.org> Cc: Zheng Yongjun <zhengyongjun3@huawei.com>, Hulk Robot <hulkci@huawei.com> Subject: [PATCH -next v2] bcache: use DEFINE_MUTEX() for mutex lock Date: Wed, 7 Apr 2021 17:38:48 +0800 [thread overview] Message-ID: <20210407093848.567720-1-zhengyongjun3@huawei.com> (raw) mutex lock can be initialized automatically with DEFINE_MUTEX() rather than explicitly calling mutex_init(). this patch will reduce the size of bcache.ko about 64 bytes, the reason as follows: though this patch will increase the size of .data segment about 32 bytes, it will also reduce the size of .init.text and .rodata.str1.1(at x86_64), .rodata_str1.8(at arm64) and .bss segment total about 96 bytes which reduce the size more than .data segment; here is the statistics: Sections: (arm64 platform) Idx name size -.init.text 00000240 +.init.text 00000228 -.rodata.str1.8 000012cd +.rodata.str1.8 000012b5 -.data 00000c60 +.data 00000c80 -.bss 00000080 +.bss 00000060 Sections: (x86 platform) Idx name size -.init.text 000001d9 +.init.text 000001bf -.rodata.str1.1 00000c80 +.rodata.str1.1 00000c6d -.data 00000cc0 +.data 00000ce0 -.bss 00000080 +.bss 00000070 Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com> --- drivers/md/bcache/super.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index 03e1fe4de53d..3635f454309e 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -40,7 +40,7 @@ static const char invalid_uuid[] = { }; static struct kobject *bcache_kobj; -struct mutex bch_register_lock; +DEFINE_MUTEX(bch_register_lock); bool bcache_is_reboot; LIST_HEAD(bch_cache_sets); static LIST_HEAD(uncached_devices); @@ -2869,7 +2869,6 @@ static int __init bcache_init(void) check_module_parameters(); - mutex_init(&bch_register_lock); init_waitqueue_head(&unregister_wait); register_reboot_notifier(&reboot); -- 2.25.1
next reply other threads:[~2021-04-07 9:24 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-07 9:38 Zheng Yongjun [this message] 2021-04-07 9:49 ` Coly Li 2021-04-07 12:18 ` 答复: " zhengyongjun
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210407093848.567720-1-zhengyongjun3@huawei.com \ --to=zhengyongjun3@huawei.com \ --cc=colyli@suse.de \ --cc=hulkci@huawei.com \ --cc=kent.overstreet@gmail.com \ --cc=linux-bcache@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --subject='Re: [PATCH -next v2] bcache: use DEFINE_MUTEX() for mutex lock' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).