From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB63FC433B4 for ; Mon, 19 Apr 2021 12:56:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B4D5761107 for ; Mon, 19 Apr 2021 12:56:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233310AbhDSM5A (ORCPT ); Mon, 19 Apr 2021 08:57:00 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:58929 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232709AbhDSM47 (ORCPT ); Mon, 19 Apr 2021 08:56:59 -0400 Received: from 1.general.cking.uk.vpn ([10.172.193.212] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1lYTS0-0001Z9-7b; Mon, 19 Apr 2021 12:56:28 +0000 From: Colin King To: Coly Li , Kent Overstreet , Jens Axboe , Jianpeng Ma , linux-bcache@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] bcache: Set error return err to -ENOMEM on allocation failure Date: Mon, 19 Apr 2021 13:56:27 +0100 Message-Id: <20210419125628.177047-1-colin.king@canonical.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org From: Colin Ian King Currently when ns fails to be allocated the error return path returns an uninitialized return code in variable 'err'. Fix this by setting err to -ENOMEM. Addresses-Coverity: ("Uninitialized scalar variable") Fixes: 688330711e9a ("bcache: initialize the nvm pages allocator") Signed-off-by: Colin Ian King --- drivers/md/bcache/nvm-pages.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/md/bcache/nvm-pages.c b/drivers/md/bcache/nvm-pages.c index 08cd45e90481..2e124d546099 100644 --- a/drivers/md/bcache/nvm-pages.c +++ b/drivers/md/bcache/nvm-pages.c @@ -584,6 +584,7 @@ struct bch_nvm_namespace *bch_register_namespace(const char *dev_path) return ERR_PTR(PTR_ERR(bdev)); } + err = -ENOMEM; ns = kzalloc(sizeof(struct bch_nvm_namespace), GFP_KERNEL); if (!ns) goto bdput; -- 2.30.2