From: Arnd Bergmann <arnd@kernel.org>
To: Coly Li <colyli@suse.de>,
Kent Overstreet <kent.overstreet@gmail.com>,
Jens Axboe <axboe@kernel.dk>, Jianpeng Ma <jianpeng.ma@intel.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Jean Delvare <jdelvare@suse.de>,
linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] bcache: add BLK_DEV dependency for BCACHE_NVM_PAGES
Date: Wed, 21 Apr 2021 15:50:16 +0200 [thread overview]
Message-ID: <20210421135021.3360382-1-arnd@kernel.org> (raw)
From: Arnd Bergmann <arnd@arndb.de>
Selecting this without CONFIG_BLK_DEV causes a Kconfig warning:
WARNING: unmet direct dependencies detected for LIBNVDIMM
Depends on [n]: PHYS_ADDR_T_64BIT [=y] && HAS_IOMEM [=y] && BLK_DEV [=n]
Selected by [y]:
- BCACHE_NVM_PAGES [=y] && MD [=y] && BCACHE [=y] && PHYS_ADDR_T_64BIT [=y]
Add it as another dependency.
Fixes: 688330711e9a ("bcache: initialize the nvm pages allocator")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/md/bcache/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/md/bcache/Kconfig b/drivers/md/bcache/Kconfig
index 0996e366ad0b..9cb3d8c39fc1 100644
--- a/drivers/md/bcache/Kconfig
+++ b/drivers/md/bcache/Kconfig
@@ -40,6 +40,7 @@ config BCACHE_NVM_PAGES
bool "NVDIMM support for bcache (EXPERIMENTAL)"
depends on BCACHE
depends on PHYS_ADDR_T_64BIT
+ depends on BLKDEV
select LIBNVDIMM
select DAX
help
--
2.29.2
next reply other threads:[~2021-04-21 13:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 13:50 Arnd Bergmann [this message]
2021-04-21 14:17 ` [PATCH] bcache: add BLK_DEV dependency for BCACHE_NVM_PAGES Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210421135021.3360382-1-arnd@kernel.org \
--to=arnd@kernel.org \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=colyli@suse.de \
--cc=jdelvare@suse.de \
--cc=jianpeng.ma@intel.com \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).