archive mirror
 help / color / mirror / Atom feed
From: Zheng Yongjun <>
To: <>, <>,
	<>, <>
Cc: Zheng Yongjun <>, Hulk Robot <>
Subject: [PATCH -next v4] bcache: Use DEFINE_MUTEX() for mutex lock
Date: Wed, 5 May 2021 19:06:55 +0800	[thread overview]
Message-ID: <> (raw)

Mutex lock can be initialized automatically with DEFINE_MUTEX() rather
than explicitly calling mutex_init().

This patch will reduce the size of bcache.ko about 16 bytes, the
reason as follows:

Though this patch will increase the size of .data segment about 32
bytes, it will also reduce the size of .init.text and
.rodata.str1.1(at x86_64), .rodata_str1.8(at arm64) total about 48
bytes which reduce the size more than .data segment;

Here is the statistics:
Sections: (arm64 platform)
Idx name                size
-.init.text             00000240
+.init.text             00000228

-.rodata.str1.8	000012cd
+.rodata.str1.8	000012b5                  00000c60                  00000c80

Sections: (x86 platform)
Idx name                size
-.init.text             000001d9
+.init.text             000001bf

-.rodata.str1.1	00000c80
+.rodata.str1.1	00000c6d                  00000cc0                  00000ce0

Reported-by: Hulk Robot <>
Signed-off-by: Zheng Yongjun <>

- change commit log, delete bss information at commit description.
- change commit log, delete statistic about .bss segment.
- add commit log about the reason why bcache.ko size reduced.
 drivers/md/bcache/super.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c
index 03e1fe4de53d..3635f454309e 100644
--- a/drivers/md/bcache/super.c
+++ b/drivers/md/bcache/super.c
@@ -40,7 +40,7 @@ static const char invalid_uuid[] = {
 static struct kobject *bcache_kobj;
-struct mutex bch_register_lock;
 bool bcache_is_reboot;
 static LIST_HEAD(uncached_devices);
@@ -2869,7 +2869,6 @@ static int __init bcache_init(void)
-	mutex_init(&bch_register_lock);

             reply	other threads:[~2021-05-05 10:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-05 11:06 Zheng Yongjun [this message]
2021-05-06  3:27 ` [PATCH -next v4] bcache: Use DEFINE_MUTEX() for mutex lock Coly Li
2021-05-06  8:32   ` 答复: " zhengyongjun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).