From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BC07C47080 for ; Mon, 24 May 2021 07:25:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F218761153 for ; Mon, 24 May 2021 07:25:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232303AbhEXH01 (ORCPT ); Mon, 24 May 2021 03:26:27 -0400 Received: from verein.lst.de ([213.95.11.211]:53457 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232249AbhEXH01 (ORCPT ); Mon, 24 May 2021 03:26:27 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 08B3867373; Mon, 24 May 2021 09:24:57 +0200 (CEST) Date: Mon, 24 May 2021 09:24:56 +0200 From: Christoph Hellwig To: Hannes Reinecke Cc: Christoph Hellwig , Jens Axboe , Geert Uytterhoeven , Chris Zankel , Max Filippov , Philipp Reisner , Lars Ellenberg , Jim Paris , Joshua Morris , Philip Kelleher , Minchan Kim , Nitin Gupta , Matias Bjorling , Coly Li , Mike Snitzer , Song Liu , Maxim Levitsky , Alex Dubov , Ulf Hansson , Dan Williams , Vishal Verma , Dave Jiang , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , linux-block@vger.kernel.org, dm-devel@redhat.com, linux-m68k@lists.linux-m68k.org, linux-xtensa@linux-xtensa.org, drbd-dev@lists.linbit.com, linuxppc-dev@lists.ozlabs.org, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, nvdimm@lists.linux.dev, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org Subject: Re: [PATCH 06/26] brd: convert to blk_alloc_disk/blk_cleanup_disk Message-ID: <20210524072456.GD23890@lst.de> References: <20210521055116.1053587-1-hch@lst.de> <20210521055116.1053587-7-hch@lst.de> <83fc5cdc-53ed-0bd3-fbe8-93d0afd20771@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83fc5cdc-53ed-0bd3-fbe8-93d0afd20771@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org On Sun, May 23, 2021 at 09:58:48AM +0200, Hannes Reinecke wrote: >> + /* >> + * This is so fdisk will align partitions on 4k, because of >> + * direct_access API needing 4k alignment, returning a PFN >> + * (This is only a problem on very small devices <= 4M, >> + * otherwise fdisk will align on 1M. Regardless this call >> + * is harmless) >> + */ >> + blk_queue_physical_block_size(disk->queue, PAGE_SIZE); >> > > Maybe converting the comment to refer to 'PAGE_SIZE' instead of 4k while > you're at it ... I really do not want to touch these kinds of unrelated things here.