linux-bcache.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Richard Weinberger <richard@nod.at>,
	Anton Ivanov <anton.ivanov@cambridgegreys.com>,
	Geoff Levand <geoff@infradead.org>,
	Ilya Dryomov <idryomov@gmail.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>, Song Liu <song@kernel.org>,
	Mike Snitzer <snitzer@redhat.com>, Coly Li <colyli@suse.de>,
	Stefan Haberland <sth@linux.ibm.com>,
	Jan Hoeppner <hoeppner@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Phillip Lougher <phillip@squashfs.org.uk>,
	linux-block@vger.kernel.org, dm-devel@redhat.com,
	linux-um@lists.infradead.org, ceph-devel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org,
	linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCH 15/15] nvme: use bvec_virt
Date: Wed, 4 Aug 2021 07:33:12 -0700	[thread overview]
Message-ID: <20210804143312.GA2296276@dhcp-10-100-145-180.wdc.com> (raw)
In-Reply-To: <20210804095634.460779-16-hch@lst.de>

On Wed, Aug 04, 2021 at 11:56:34AM +0200, Christoph Hellwig wrote:
> Use bvec_virt instead of open coding it.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  drivers/nvme/host/core.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index dfd9dec0c1f6..02ce94b2906b 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -968,12 +968,11 @@ void nvme_cleanup_cmd(struct request *req)
>  {
>  	if (req->rq_flags & RQF_SPECIAL_PAYLOAD) {
>  		struct nvme_ctrl *ctrl = nvme_req(req)->ctrl;
> -		struct page *page = req->special_vec.bv_page;
>  
> -		if (page == ctrl->discard_page)
> +		if (req->special_vec.bv_page == ctrl->discard_page)
>  			clear_bit_unlock(0, &ctrl->discard_page_busy);
>  		else
> -			kfree(page_address(page) + req->special_vec.bv_offset);
> +			kfree(bvec_virt(&req->special_vec));
>  	}
>  }
>  EXPORT_SYMBOL_GPL(nvme_cleanup_cmd);

Looks good.

Reviewed-by: Keith Busch <kbusch@kernel.org>

  reply	other threads:[~2021-08-04 14:33 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-04  9:56 add a bvec_virt helper Christoph Hellwig
2021-08-04  9:56 ` [PATCH 01/15] bvec: " Christoph Hellwig
2021-08-05  6:19   ` Chaitanya Kulkarni
2021-08-06  2:38   ` Martin K. Petersen
2021-08-04  9:56 ` [PATCH 02/15] block: use bvec_virt in bio_integrity_{process,free} Christoph Hellwig
2021-08-05  6:19   ` Chaitanya Kulkarni
2021-08-06  2:38   ` Martin K. Petersen
2021-08-04  9:56 ` [PATCH 03/15] dm: make EBS depend on !HIGHMEM Christoph Hellwig
2021-08-04  9:56 ` [PATCH 04/15] dm-ebs: use bvec_virt Christoph Hellwig
2021-08-04  9:56 ` [PATCH 05/15] dm-integrity: " Christoph Hellwig
2021-08-04  9:56 ` [PATCH 06/15] squashfs: " Christoph Hellwig
2021-08-04  9:56 ` [PATCH 07/15] rbd: " Christoph Hellwig
2021-08-05 12:01   ` Jeff Layton
2021-08-04  9:56 ` [PATCH 08/15] virtio_blk: " Christoph Hellwig
2021-08-05 14:17   ` Stefan Hajnoczi
2021-08-04  9:56 ` [PATCH 09/15] bcache: " Christoph Hellwig
2021-08-04 17:05   ` Coly Li
2021-08-04  9:56 ` [PATCH 10/15] sd: " Christoph Hellwig
2021-08-05 16:31   ` [dm-devel] " Bart Van Assche
2021-08-06  2:43   ` Martin K. Petersen
2021-08-04  9:56 ` [PATCH 11/15] ubd: " Christoph Hellwig
2021-08-04 10:10   ` Anton Ivanov
2021-08-04  9:56 ` [PATCH 12/15] ps3vram: " Christoph Hellwig
2021-08-04  9:56 ` [PATCH 13/15] dasd: " Christoph Hellwig
2021-08-04 20:20   ` Stefan Haberland
2021-08-04  9:56 ` [PATCH 14/15] dcssblk: " Christoph Hellwig
2021-08-04  9:56 ` [PATCH 15/15] nvme: " Christoph Hellwig
2021-08-04 14:33   ` Keith Busch [this message]
2021-08-16 12:38 ` add a bvec_virt helper Christoph Hellwig
2021-08-16 16:51 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210804143312.GA2296276@dhcp-10-100-145-180.wdc.com \
    --to=kbusch@kernel.org \
    --cc=anton.ivanov@cambridgegreys.com \
    --cc=axboe@kernel.dk \
    --cc=ceph-devel@vger.kernel.org \
    --cc=colyli@suse.de \
    --cc=dm-devel@redhat.com \
    --cc=geoff@infradead.org \
    --cc=hch@lst.de \
    --cc=hoeppner@linux.ibm.com \
    --cc=idryomov@gmail.com \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-um@lists.infradead.org \
    --cc=martin.petersen@oracle.com \
    --cc=pbonzini@redhat.com \
    --cc=phillip@squashfs.org.uk \
    --cc=richard@nod.at \
    --cc=snitzer@redhat.com \
    --cc=song@kernel.org \
    --cc=stefanha@redhat.com \
    --cc=sth@linux.ibm.com \
    --cc=virtualization@lists.linux-foundation.org \
    --subject='Re: [PATCH 15/15] nvme: use bvec_virt' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).