Re: [PATCH] bcache: set io_disable to true when stop bcache device

From: kernel test robot <lkp@intel.com>
To: mingzhe <mingzhe.zou@easystack.cn>,
	colyli@suse.de, bcache@lists.ewheeler.net
Cc: oe-kbuild-all@lists.linux.dev, linux-bcache@vger.kernel.org,
	zoumingzhe@qq.com
Subject: Re: [PATCH] bcache: set io_disable to true when stop bcache device
Date: Wed, 8 Mar 2023 20:16:49 +0800	[thread overview]
Message-ID: <202303082025.PP1BZsDY-lkp@intel.com> (raw)
In-Reply-To: <20230308092036.11024-1-mingzhe.zou@easystack.cn>

Hi mingzhe,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v6.3-rc1 next-20230308]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/mingzhe/bcache-set-io_disable-to-true-when-stop-bcache-device/20230308-172245
patch link:    https://lore.kernel.org/r/20230308092036.11024-1-mingzhe.zou%40easystack.cn
patch subject: [PATCH] bcache: set io_disable to true when stop bcache device
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230308/202303082025.PP1BZsDY-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/6a59a84151f42d58e6010f18c92b98cbaf58bdc1
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review mingzhe/bcache-set-io_disable-to-true-when-stop-bcache-device/20230308-172245
        git checkout 6a59a84151f42d58e6010f18c92b98cbaf58bdc1
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 olddefconfig
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/md/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303082025.PP1BZsDY-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/md/bcache/request.c: In function 'cached_dev_bio_fail':
>> drivers/md/bcache/request.c:764:28: warning: unused variable 'dc' [-Wunused-variable]
     764 |         struct cached_dev *dc = container_of(s->d, struct cached_dev, disk);
         |                            ^~

vim +/dc +764 drivers/md/bcache/request.c

   760	
   761	static void cached_dev_bio_fail(struct closure *cl)
   762	{
   763		struct search *s = container_of(cl, struct search, cl);
 > 764		struct cached_dev *dc = container_of(s->d, struct cached_dev, disk);
   765	
   766		s->iop.status = BLK_STS_IOERR;
   767		cached_dev_bio_complete(cl);
   768	}
   769	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests