From: Coly Li <colyli@suse.de>
To: Nix <nix@esperi.org.uk>
Cc: linux-bcache@vger.kernel.org
Subject: Re: [PATCH v4] bcache: avoid oversized read request in cache missing code path
Date: Thu, 27 May 2021 10:55:12 +0800 [thread overview]
Message-ID: <2ca4d125-c1d0-0ed0-f654-1b816432ed2e@suse.de> (raw)
In-Reply-To: <87tumpiiyz.fsf@esperi.org.uk>
On 5/26/21 11:59 PM, Nix wrote:
> On 26 May 2021, Coly Li said:
>> Current problmatic code can be partially found since Linux v5.13-rc1,
>> therefore all maintained stable kernels should try to apply this fix.
>
> I thought this crash was observed with 5.12 originally? (I know that's
> why I'm still on 5.11 :) )
>
My typo, sigh....
The problematic code was in such form since Linux v3.13-rc1,
- the bio related panic was explicitly triggered due to bio changes
since v5.12.
- the overflowed bkey size issue exists for long time too, just no one
reports it before.
Maybe the issue can be found in pre-v3.13 code, but I don't check
because the code logic was not in current form.
Thank you for figure out the typo, I will fix it in next version.
Coly Li
next prev parent reply other threads:[~2021-05-27 2:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 15:14 [PATCH v4] bcache: avoid oversized read request in cache missing code path Coly Li
2021-05-26 15:59 ` Nix
2021-05-27 2:55 ` Coly Li [this message]
2021-05-27 11:36 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ca4d125-c1d0-0ed0-f654-1b816432ed2e@suse.de \
--to=colyli@suse.de \
--cc=linux-bcache@vger.kernel.org \
--cc=nix@esperi.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).