From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 293A2C4743C for ; Wed, 23 Jun 2021 06:03:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0EBD661186 for ; Wed, 23 Jun 2021 06:03:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229915AbhFWGGP (ORCPT ); Wed, 23 Jun 2021 02:06:15 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:42594 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229800AbhFWGGO (ORCPT ); Wed, 23 Jun 2021 02:06:14 -0400 Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B425B2191C; Wed, 23 Jun 2021 06:03:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1624428236; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e/75pFNjbtFEvejhPibGMochJt2tfZuidrpJaHOLw8I=; b=hkrnaIK9M0eb3tT42Rk8IVdBbnzWimMqfDtg4OFyOdl/bgWK07BQLKDwoluQCBIOycBeH9 oN4vENH5WQzT/WRb5HY/s5dRD3wkVLl0iX18K++hZow5k7+YBrut0JyeKlbE7p4sd6oUq1 XD5noHeM02EoeueSxmVwBtkRaf7bVco= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1624428236; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e/75pFNjbtFEvejhPibGMochJt2tfZuidrpJaHOLw8I=; b=eS8Q2TZZpquJPtZm9Gi+vghpsPTSMwFA9rjE49404l9qR3B7roTdGVGlYjkUSLCVzc1HVb 1ULsFqEBuD4IoQAA== Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id B2F2111A97; Wed, 23 Jun 2021 06:03:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1624428236; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e/75pFNjbtFEvejhPibGMochJt2tfZuidrpJaHOLw8I=; b=hkrnaIK9M0eb3tT42Rk8IVdBbnzWimMqfDtg4OFyOdl/bgWK07BQLKDwoluQCBIOycBeH9 oN4vENH5WQzT/WRb5HY/s5dRD3wkVLl0iX18K++hZow5k7+YBrut0JyeKlbE7p4sd6oUq1 XD5noHeM02EoeueSxmVwBtkRaf7bVco= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1624428236; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e/75pFNjbtFEvejhPibGMochJt2tfZuidrpJaHOLw8I=; b=eS8Q2TZZpquJPtZm9Gi+vghpsPTSMwFA9rjE49404l9qR3B7roTdGVGlYjkUSLCVzc1HVb 1ULsFqEBuD4IoQAA== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id yxd5IMrO0mCoXAAALh3uQQ (envelope-from ); Wed, 23 Jun 2021 06:03:54 +0000 Subject: Re: [PATCH 05/14] bcache: initialization of the buddy To: Pavel Goran Cc: Hannes Reinecke , linux-bcache@vger.kernel.org, linux-block@vger.kernel.org, Jianpeng Ma , kernel test robot , Dan Carpenter , axboe@kernel.dk, Qiaowei Ren References: <20210615054921.101421-1-colyli@suse.de> <20210615054921.101421-6-colyli@suse.de> <133698796.20210623124604@pvgoran.name> From: Coly Li Message-ID: <3e1c9885-1f8f-a501-3e33-66794ed54fce@suse.de> Date: Wed, 23 Jun 2021 14:03:52 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <133698796.20210623124604@pvgoran.name> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org On 6/23/21 1:46 PM, Pavel Goran wrote: > Hello Coly, > > Wednesday, June 23, 2021, 12:35:21 PM, you wrote: > >> ... (skipped a lot) >>>> + /* recs array can has hole */ >>> can have holes ? >> It means the valid record is not always continuously stored in recs[] >> from struct bch_nvm_pgalloc_recs. Because currently only 8 bytes write >> to a 8 bytes aligned address on NVDIMM is stomic for power failure. >> ... > The issue is with the wording of this comment, not with the code or the > meaning of the comment. > > The comment should read "recs array can have hole". Oh, I see. Thank Pavel for the hint :-) We will update it in next post. Coly Li