From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56AF6C433DF for ; Wed, 15 Jul 2020 06:08:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 37E782065D for ; Wed, 15 Jul 2020 06:08:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727049AbgGOGIt (ORCPT ); Wed, 15 Jul 2020 02:08:49 -0400 Received: from [195.135.220.15] ([195.135.220.15]:44128 "EHLO mx2.suse.de" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1725866AbgGOGIt (ORCPT ); Wed, 15 Jul 2020 02:08:49 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 16B2AAD2C; Wed, 15 Jul 2020 06:08:51 +0000 (UTC) Subject: Re: [PATCH v2 04/17] bcache: disassemble the big if() checks in bch_cache_set_alloc() To: Coly Li , linux-bcache@vger.kernel.org Cc: linux-block@vger.kernel.org References: <20200715054612.6349-1-colyli@suse.de> <20200715054612.6349-5-colyli@suse.de> From: Hannes Reinecke Message-ID: <41581c3d-90a2-33dc-26c3-2cd11edd3429@suse.de> Date: Wed, 15 Jul 2020 08:08:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200715054612.6349-5-colyli@suse.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-bcache-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org On 7/15/20 7:45 AM, Coly Li wrote: > In bch_cache_set_alloc() there is a big if() checks combined by 11 items > together. When this big if() statement fails, it is difficult to tell > exactly which item fails indeed. > > This patch disassembles this big if() checks into 11 single if() checks, > which makes code debug more easier. > > Signed-off-by: Coly Li > --- > drivers/md/bcache/super.c | 52 ++++++++++++++++++++++++++++----------- > 1 file changed, 37 insertions(+), 15 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer