linux-bcache.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Coly Li <colyli@suse.de>
To: Marco Rebhan <me@dblsaiko.net>
Cc: linux-bcache@vger.kernel.org, victor@westerhu.is
Subject: Re: Kernel Oops: kernel BUG at block/bio.c:52
Date: Thu, 6 May 2021 18:04:00 +0800	[thread overview]
Message-ID: <4b6c9608-84e9-e20b-ac84-c4fd0a536f29@suse.de> (raw)
In-Reply-To: <1783900.tdWV9SEqCh@invader>

On 5/6/21 3:36 PM, Marco Rebhan wrote:
> On Thursday, 6 May 2021 04:50:06 CEST Coly Li wrote:
>> Could you please try the attached patch ?  If a suspicious bio
>> allocation happens, this patch will print out a warning kernel message
>> and avoid the BUG() panic.
> 
> Looks like the patch works. Here's a dmesg log that comes from starting
> up a game with a bunch of large files (which I'm guessing are what
> makes this happen more often?)
> 

Before 5.12, the allocation failure returns a NULL pointer, so such
issue was hidden. I will post a quick fix to emulate previous code logic
without bothering bio_alloc_bioset().

Thanks for the quick test and verification.

Coly Li


> [   39.284230] bcache: cached_dev_cache_miss() inserting bio is too large: 344 iovecs, not intsert.
> [   65.415896] bcache: cached_dev_cache_miss() inserting bio is too large: 282 iovecs, not intsert.
> [   65.446327] bcache: cached_dev_cache_miss() inserting bio is too large: 946 iovecs, not intsert.
> [   88.116826] bcache: cached_dev_cache_miss() inserting bio is too large: 342 iovecs, not intsert.
> [   88.957691] bcache: cached_dev_cache_miss() inserting bio is too large: 342 iovecs, not intsert.
> [   89.020544] bcache: cached_dev_cache_miss() inserting bio is too large: 332 iovecs, not intsert.
> [   90.531875] bcache: cached_dev_cache_miss() inserting bio is too large: 261 iovecs, not intsert.
> [  111.464124] bcache: cached_dev_cache_miss() inserting bio is too large: 342 iovecs, not intsert.
> [  111.497049] bcache: cached_dev_cache_miss() inserting bio is too large: 262 iovecs, not intsert.
> [  111.638928] bcache: cached_dev_cache_miss() inserting bio is too large: 318 iovecs, not intsert.
> [  155.884142] bcache: cached_dev_cache_miss() inserting bio is too large: 447 iovecs, not intsert.
> [  156.146070] bcache: cached_dev_cache_miss() inserting bio is too large: 512 iovecs, not intsert.
> [  156.223795] bcache: cached_dev_cache_miss() inserting bio is too large: 277 iovecs, not intsert.
> [  156.326145] bcache: cached_dev_cache_miss() inserting bio is too large: 342 iovecs, not intsert.
> [  156.602906] bcache: cached_dev_cache_miss() inserting bio is too large: 290 iovecs, not intsert.
> [  156.646365] bcache: cached_dev_cache_miss() inserting bio is too large: 341 iovecs, not intsert.
> [  156.671285] bcache: cached_dev_cache_miss() inserting bio is too large: 501 iovecs, not intsert.
> [  157.216087] bcache: cached_dev_cache_miss() inserting bio is too large: 258 iovecs, not intsert.
> [  165.010961] bcache: cached_dev_cache_miss() inserting bio is too large: 413 iovecs, not intsert.
> [  165.386483] bcache: cached_dev_cache_miss() inserting bio is too large: 260 iovecs, not intsert.
> 
> Thanks,
> Marco
> 


  reply	other threads:[~2021-05-06 10:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-20 14:54 Kernel Oops: kernel BUG at block/bio.c:52 Victor Westerhuis
2021-04-20 16:14 ` Coly Li
2021-04-27 18:57   ` Marco Rebhan
2021-05-06  2:50     ` Coly Li
2021-05-06  7:36       ` Marco Rebhan
2021-05-06 10:04         ` Coly Li [this message]
2021-05-06 15:46           ` Marco Rebhan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4b6c9608-84e9-e20b-ac84-c4fd0a536f29@suse.de \
    --to=colyli@suse.de \
    --cc=linux-bcache@vger.kernel.org \
    --cc=me@dblsaiko.net \
    --cc=victor@westerhu.is \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).