From: Coly Li <colyli@suse.de>
To: axboe@kernel.dk
Cc: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org,
stable@vger.kernel.org,
Bockholdt Arne <a.bockholdt@precitec-optronik.de>
Subject: Re: [PATCH] bcache: only check feature sets when sb->version >= BCACHE_SB_VERSION_CDEV_WITH_FEATURES
Date: Thu, 28 Jan 2021 18:57:20 +0800 [thread overview]
Message-ID: <69e0beed-9667-7d28-04cf-418e9a996038@suse.de> (raw)
In-Reply-To: <20210128104847.22773-1-colyli@suse.de>
On 1/28/21 6:48 PM, Coly Li wrote:
> For super block version < BCACHE_SB_VERSION_CDEV_WITH_FEATURES, it
> doesn't make sense to check the feature sets. This patch checks
> super block version in bch_has_feature_* routines, if the version
> doesn't have feature sets yet, returns 0 (false) to the caller.
>
> Fixes: 5342fd425502 ("bcache: set bcache device into read-only mode for BCH_FEATURE_INCOMPAT_OBSO_LARGE_BUCKET")
> Fixes: ffa470327572 ("bcache: add bucket_size_hi into struct cache_sb_disk for large bucket")
> Cc: stable@vger.kernel.org # 5.9+
> Reported-and-tested-by: Bockholdt Arne <a.bockholdt@precitec-optronik.de>
> Signed-off-by: Coly Li <colyli@suse.de>
Hi Jens,
Please take this patch for v5.11-rc6, this is necessary to go with other
fixes in previous wave.
Thank you in advance.
Coly Li
> ---
> drivers/md/bcache/features.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/md/bcache/features.h b/drivers/md/bcache/features.h
> index 84fc2c0f0101..d1c8fd3977fc 100644
> --- a/drivers/md/bcache/features.h
> +++ b/drivers/md/bcache/features.h
> @@ -33,6 +33,8 @@
> #define BCH_FEATURE_COMPAT_FUNCS(name, flagname) \
> static inline int bch_has_feature_##name(struct cache_sb *sb) \
> { \
> + if (sb->version < BCACHE_SB_VERSION_CDEV_WITH_FEATURES) \
> + return 0; \
> return (((sb)->feature_compat & \
> BCH##_FEATURE_COMPAT_##flagname) != 0); \
> } \
> @@ -50,6 +52,8 @@ static inline void bch_clear_feature_##name(struct cache_sb *sb) \
> #define BCH_FEATURE_RO_COMPAT_FUNCS(name, flagname) \
> static inline int bch_has_feature_##name(struct cache_sb *sb) \
> { \
> + if (sb->version < BCACHE_SB_VERSION_CDEV_WITH_FEATURES) \
> + return 0; \
> return (((sb)->feature_ro_compat & \
> BCH##_FEATURE_RO_COMPAT_##flagname) != 0); \
> } \
> @@ -67,6 +71,8 @@ static inline void bch_clear_feature_##name(struct cache_sb *sb) \
> #define BCH_FEATURE_INCOMPAT_FUNCS(name, flagname) \
> static inline int bch_has_feature_##name(struct cache_sb *sb) \
> { \
> + if (sb->version < BCACHE_SB_VERSION_CDEV_WITH_FEATURES) \
> + return 0; \
> return (((sb)->feature_incompat & \
> BCH##_FEATURE_INCOMPAT_##flagname) != 0); \
> } \
>
next prev parent reply other threads:[~2021-01-28 10:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 10:48 [PATCH] bcache: only check feature sets when sb->version >= BCACHE_SB_VERSION_CDEV_WITH_FEATURES Coly Li
2021-01-28 10:57 ` Coly Li [this message]
2021-01-28 14:35 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69e0beed-9667-7d28-04cf-418e9a996038@suse.de \
--to=colyli@suse.de \
--cc=a.bockholdt@precitec-optronik.de \
--cc=axboe@kernel.dk \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).