From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: remove dead bdi congestion leftovers Date: Thu, 9 Jul 2020 07:58:58 -0600 Message-ID: <82e2785d-2091-1986-0014-3b7cea7cd0d8@kernel.dk> References: <20200701090622.3354860-1-hch@lst.de> <20200709053233.GA3243@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20200709053233.GA3243-jcswGhMUV9g@public.gmane.org> Content-Language: en-US Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Christoph Hellwig Cc: Tejun Heo , dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-block-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org, linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-raid-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-btrfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-bcache@vger.kernel.org On 7/8/20 11:32 PM, Christoph Hellwig wrote: > On Wed, Jul 08, 2020 at 05:14:29PM -0600, Jens Axboe wrote: >> On 7/1/20 3:06 AM, Christoph Hellwig wrote: >>> Hi Jens, >>> >>> we have a lot of bdi congestion related code that is left around without >>> any use. This series removes it in preparation of sorting out the bdi >>> lifetime rules properly. >> >> Please run series like this through a full compilation, for both this one >> and the previous series I had to fix up issues like this: >> >> drivers/md/bcache/request.c: In function ‘bch_cached_dev_request_init’: >> drivers/md/bcache/request.c:1233:18: warning: unused variable ‘g’ [-Wunused-variable] >> 1233 | struct gendisk *g = dc->disk.disk; >> | ^ >> drivers/md/bcache/request.c: In function ‘bch_flash_dev_request_init’: >> drivers/md/bcache/request.c:1320:18: warning: unused variable ‘g’ [-Wunused-variable] >> 1320 | struct gendisk *g = d->disk; >> | ^ >> >> Did the same here, applied it. > > And just like the previous one I did, and the compiler did not complain. > There must be something about certain gcc versions not warning about > variables that are initialized but not otherwise used. Are you using gcc-10? It sucks for that. gcc-9 seems to reliably hit these cases for me, not sure why gcc-10 doesn't. And the ones quoted above are about as trivial as they can get. -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B081FC433E3 for ; Thu, 9 Jul 2020 13:59:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8F35F20708 for ; Thu, 9 Jul 2020 13:59:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="coM9AtJu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727969AbgGIN7B (ORCPT ); Thu, 9 Jul 2020 09:59:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727856AbgGIN7A (ORCPT ); Thu, 9 Jul 2020 09:59:00 -0400 Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 967E5C08C5DC for ; Thu, 9 Jul 2020 06:59:00 -0700 (PDT) Received: by mail-io1-xd42.google.com with SMTP id c16so2372263ioi.9 for ; Thu, 09 Jul 2020 06:59:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ttUciq1R4DLXwSrCKOG8sMg2/ZhVL4qipuIgKqQy2hE=; b=coM9AtJu0ST+XR8OMgywQuHtTrKC9/b3RSDkB5xLiy4QzbX3T0Aw61rbH1CahgBBuR uHGxD5IVaENFxujEI50kNZMa4M546fERlVcPXVLx0073TNTIByYun/g+RHhX1WEDPk90 nLVTJFCuIlptJdGLVxMiS/3WV+WEeYk/uPnJy7GYNSE5TcqY5Sk+XRfP9o7wxQhjTuBd OfxdrSK1xj7iSzi0tqotyg0P0tyJIhgxoopV77fateMyHS2NoNRk3u2YMgfEUz9jt+Mx I7oNOyQ+dlAawprLARe5BTTjR91BKrEJGHW7LfKtefXB0VFKSsrdcDKI81gtPbkU0jfv Jz9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ttUciq1R4DLXwSrCKOG8sMg2/ZhVL4qipuIgKqQy2hE=; b=nk6HDUufX1g7dA8HUOMdInuO/CzVHBRsxKlc4pxVZzgBlx/K/9rrfLNt8wCMlssWSD mqNupnkMK607tnYyjCevVe6bMSUbZVoMB9ixarUQMzvkEQmxtMeAO+YgmD9Mf1s8njWy D1TqxzvB2CHyFgrYZxLS6tUGmhNYdeAJI4KGmMzSWQ51PjjSucSCXXJRY11+0pYYboqH tpPuQQP4XhYczOg2tEUIMp2dcxjj6ob3I7hTH6BpM8P9Ku6HDQQhTlYwQXOLG3HGDQeC xKbc7AGdPY8nLfGMiDqPZoihw98wU88dhyo4bRk43zA3mINw7w7Nwi+j48q+Oay8ezx5 IIIw== X-Gm-Message-State: AOAM533pYj36NI/son17uX2lccT26BHUIHfb5Lt3VtaYk0b9UjjAXTzJ JjnT1Pq/dPMtXmb8Cnljncg7bA== X-Google-Smtp-Source: ABdhPJwILxLSUCxDdCac/fZUN7tHM3l14dJ0zrZ6D/Tc1v+OsXoh2HYNZYg6WBqjtOr30hdwGoEJQw== X-Received: by 2002:a05:6638:168e:: with SMTP id f14mr67991477jat.64.1594303139999; Thu, 09 Jul 2020 06:58:59 -0700 (PDT) Received: from [192.168.1.58] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id a1sm1884363ilq.50.2020.07.09.06.58.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jul 2020 06:58:59 -0700 (PDT) Subject: Re: remove dead bdi congestion leftovers To: Christoph Hellwig Cc: Tejun Heo , dm-devel@redhat.com, cgroups@vger.kernel.org, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20200701090622.3354860-1-hch@lst.de> <20200709053233.GA3243@lst.de> From: Jens Axboe Message-ID: <82e2785d-2091-1986-0014-3b7cea7cd0d8@kernel.dk> Date: Thu, 9 Jul 2020 07:58:58 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200709053233.GA3243@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-bcache-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org Message-ID: <20200709135858.zw8dTV-G0ZxPd0KLKZSIjsjsv7ayeu8WgxJcoUlxhEA@z> On 7/8/20 11:32 PM, Christoph Hellwig wrote: > On Wed, Jul 08, 2020 at 05:14:29PM -0600, Jens Axboe wrote: >> On 7/1/20 3:06 AM, Christoph Hellwig wrote: >>> Hi Jens, >>> >>> we have a lot of bdi congestion related code that is left around without >>> any use. This series removes it in preparation of sorting out the bdi >>> lifetime rules properly. >> >> Please run series like this through a full compilation, for both this one >> and the previous series I had to fix up issues like this: >> >> drivers/md/bcache/request.c: In function ‘bch_cached_dev_request_init’: >> drivers/md/bcache/request.c:1233:18: warning: unused variable ‘g’ [-Wunused-variable] >> 1233 | struct gendisk *g = dc->disk.disk; >> | ^ >> drivers/md/bcache/request.c: In function ‘bch_flash_dev_request_init’: >> drivers/md/bcache/request.c:1320:18: warning: unused variable ‘g’ [-Wunused-variable] >> 1320 | struct gendisk *g = d->disk; >> | ^ >> >> Did the same here, applied it. > > And just like the previous one I did, and the compiler did not complain. > There must be something about certain gcc versions not warning about > variables that are initialized but not otherwise used. Are you using gcc-10? It sucks for that. gcc-9 seems to reliably hit these cases for me, not sure why gcc-10 doesn't. And the ones quoted above are about as trivial as they can get. -- Jens Axboe