From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73325C433B4 for ; Mon, 19 Apr 2021 16:05:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D08261354 for ; Mon, 19 Apr 2021 16:05:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233739AbhDSQGE (ORCPT ); Mon, 19 Apr 2021 12:06:04 -0400 Received: from mx2.suse.de ([195.135.220.15]:54124 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232161AbhDSQEq (ORCPT ); Mon, 19 Apr 2021 12:04:46 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 26BC0AF48; Mon, 19 Apr 2021 16:04:15 +0000 (UTC) Subject: Re: [PATCH][next] bcache: Set error return err to -ENOMEM on allocation failure To: Colin King Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, linux-bcache@vger.kernel.org, Jianpeng Ma , Jens Axboe , Kent Overstreet References: <20210419125628.177047-1-colin.king@canonical.com> From: Coly Li Message-ID: <85f515b5-05a0-5844-bed7-0287f845f491@suse.de> Date: Tue, 20 Apr 2021 00:04:10 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <20210419125628.177047-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org On 4/19/21 8:56 PM, Colin King wrote: > From: Colin Ian King > > Currently when ns fails to be allocated the error return path returns > an uninitialized return code in variable 'err'. Fix this by setting > err to -ENOMEM. > > Addresses-Coverity: ("Uninitialized scalar variable") > Fixes: 688330711e9a ("bcache: initialize the nvm pages allocator") > Signed-off-by: Colin Ian King > --- > drivers/md/bcache/nvm-pages.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/md/bcache/nvm-pages.c b/drivers/md/bcache/nvm-pages.c > index 08cd45e90481..2e124d546099 100644 > --- a/drivers/md/bcache/nvm-pages.c > +++ b/drivers/md/bcache/nvm-pages.c > @@ -584,6 +584,7 @@ struct bch_nvm_namespace *bch_register_namespace(const char *dev_path) > return ERR_PTR(PTR_ERR(bdev)); > } > > + err = -ENOMEM; > ns = kzalloc(sizeof(struct bch_nvm_namespace), GFP_KERNEL); > if (!ns) > goto bdput; > Copied, added into my queue for rc1. Thanks. Coly Li