linux-bcache.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Coly Li <colyli@suse.de>
To: Zheng Yongjun <zhengyongjun3@huawei.com>
Cc: Hulk Robot <hulkci@huawei.com>,
	kent.overstreet@gmail.com, linux-bcache@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next v4] bcache: Use DEFINE_MUTEX() for mutex lock
Date: Thu, 6 May 2021 11:27:03 +0800	[thread overview]
Message-ID: <8a60b85c-b4c3-5b4c-af1f-877980800ba7@suse.de> (raw)
In-Reply-To: <20210505110655.1461896-1-zhengyongjun3@huawei.com>

On 5/5/21 7:06 PM, Zheng Yongjun wrote:
> Mutex lock can be initialized automatically with DEFINE_MUTEX() rather
> than explicitly calling mutex_init().
> 
> This patch will reduce the size of bcache.ko about 16 bytes, the
> reason as follows:
> 
> Though this patch will increase the size of .data segment about 32
> bytes, it will also reduce the size of .init.text and
> .rodata.str1.1(at x86_64), .rodata_str1.8(at arm64) total about 48
> bytes which reduce the size more than .data segment;
> 
> Here is the statistics:
> Sections: (arm64 platform)
> Idx name                size
> -.init.text             00000240
> +.init.text             00000228
> 
> -.rodata.str1.8	000012cd
> +.rodata.str1.8	000012b5
> 
> -.data                  00000c60
> +.data                  00000c80
> 
> Sections: (x86 platform)
> Idx name                size
> -.init.text             000001d9
> +.init.text             000001bf
> 
> -.rodata.str1.1	00000c80
> +.rodata.str1.1	00000c6d
> 
> -.data                  00000cc0
> +.data                  00000ce0
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>

Added in my for-test queue.

Thanks.

Coly Li

[snipped]

  reply	other threads:[~2021-05-06  3:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-05 11:06 [PATCH -next v4] bcache: Use DEFINE_MUTEX() for mutex lock Zheng Yongjun
2021-05-06  3:27 ` Coly Li [this message]
2021-05-06  8:32   ` 答复: " zhengyongjun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a60b85c-b4c3-5b4c-af1f-877980800ba7@suse.de \
    --to=colyli@suse.de \
    --cc=hulkci@huawei.com \
    --cc=kent.overstreet@gmail.com \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zhengyongjun3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).