From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E7F9C43462 for ; Mon, 12 Apr 2021 09:57:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A249611AD for ; Mon, 12 Apr 2021 09:57:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239286AbhDLJ5e (ORCPT ); Mon, 12 Apr 2021 05:57:34 -0400 Received: from mx2.suse.de ([195.135.220.15]:52624 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242842AbhDLJyM (ORCPT ); Mon, 12 Apr 2021 05:54:12 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DEE4CAF1A; Mon, 12 Apr 2021 09:53:53 +0000 (UTC) To: Christoph Hellwig Cc: axboe@kernel.dk, linux-bcache@vger.kernel.org, linux-block@vger.kernel.org References: <20210411134316.80274-1-colyli@suse.de> <20210411134316.80274-8-colyli@suse.de> <20210412090600.GA8026@lst.de> From: Coly Li Subject: Re: [PATCH 7/7] bcache: fix a regression of code compiling failure in debug.c Message-ID: <902e1ba6-cd73-b0e8-6c17-75fccbaeb9b4@suse.de> Date: Mon, 12 Apr 2021 17:53:50 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <20210412090600.GA8026@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org On 4/12/21 5:06 PM, Christoph Hellwig wrote: > On Sun, Apr 11, 2021 at 09:43:16PM +0800, Coly Li wrote: >> The patch "bcache: remove PTR_CACHE" introduces a compiling failure in >> debug.c with following error message, >> In file included from drivers/md/bcache/bcache.h:182:0, >> from drivers/md/bcache/debug.c:9: >> drivers/md/bcache/debug.c: In function 'bch_btree_verify': >> drivers/md/bcache/debug.c:53:19: error: 'c' undeclared (first use in >> this function) >> bio_set_dev(bio, c->cache->bdev); >> ^ >> This patch fixes the regression by replacing c->cache->bdev by b->c-> >> cache->bdev. > > Why not fold this into the offending patch? > I don't know whether I can do it without authorization or agreement from original author. And I see other maintainers handling similar situation by either re-write whole patch or appending an extra fix. If you have a suggested process, I can try it out next time for similar situation. Coly Li