linux-bcache.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Coly Li <colyli@suse.de>,
	"linux-bcache@vger.kernel.org" <linux-bcache@vger.kernel.org>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 1/4] bcache: correct return value in register_nvdimm_meta()
Date: Wed, 10 Feb 2021 19:52:55 +0000	[thread overview]
Message-ID: <BYAPR04MB49652239677DD0690B61A9DE868D9@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20210210135657.35284-1-colyli@suse.de

On 2/10/21 06:00, Coly Li wrote:
> 'ret' should be used a return value, thi patch fixes this error.
How about following commit log ?

The local variable should be used to return right error code from the
register_nvdimm_meta() instead of size variable.

> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Coly Li <colyli@suse.de>
> ---
Looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>


      parent reply	other threads:[~2021-02-10 19:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10 13:56 [PATCH 1/4] bcache: correct return value in register_nvdimm_meta() Coly Li
2021-02-10 13:56 ` [PATCH 2/4] bcache: use div_u64() in init_owner_info() Coly Li
2021-02-10 19:50   ` Chaitanya Kulkarni
2021-02-10 13:56 ` [PATCH 3/4] bcache: unify code comments style in nvm-pages.c Coly Li
2021-02-10 19:49   ` Chaitanya Kulkarni
2021-02-10 13:56 ` [PATCH 4/4] bcache: fix a typo in nvme-pages.c Coly Li
2021-02-10 19:53   ` Chaitanya Kulkarni
2021-02-10 19:52 ` Chaitanya Kulkarni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR04MB49652239677DD0690B61A9DE868D9@BYAPR04MB4965.namprd04.prod.outlook.com \
    --to=chaitanya.kulkarni@wdc.com \
    --cc=colyli@suse.de \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).