From: Coly Li <colyli@suse.de>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-bcache@vger.kernel.org
Subject: Re: [PATCH] bcache: don't export tracepoints
Date: Fri, 2 Dec 2022 17:52:57 +0800 [thread overview]
Message-ID: <E6C67F90-D2B7-4D43-8289-162A0C627B00@suse.de> (raw)
In-Reply-To: <20221201063240.402246-1-hch@lst.de>
> 2022年12月1日 14:32，Christoph Hellwig <hch@lst.de> 写道：
>
> All bcache tracepoints are only used inside of bcache.ko, so there is
> no point in exporting them.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
It is fine to me.
Acked-by: Coly Li <colyli@suse.de <mailto:colyli@suse.de>>
Thanks.
Coly Li
> ---
> drivers/md/bcache/trace.c | 44 ---------------------------------------
> 1 file changed, 44 deletions(-)
>
> diff --git a/drivers/md/bcache/trace.c b/drivers/md/bcache/trace.c
> index a9a73f560c0442..600efecf9bd9de 100644
> --- a/drivers/md/bcache/trace.c
> +++ b/drivers/md/bcache/trace.c
> @@ -7,47 +7,3 @@
>
> #define CREATE_TRACE_POINTS
> #include <trace/events/bcache.h>
> -
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_request_start);
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_request_end);
> -
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_bypass_sequential);
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_bypass_congested);
> -
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_read);
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_write);
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_read_retry);
> -
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_cache_insert);
> -
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_journal_replay_key);
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_journal_write);
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_journal_full);
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_journal_entry_full);
> -
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_btree_cache_cannibalize);
> -
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_btree_read);
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_btree_write);
> -
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_btree_node_alloc);
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_btree_node_alloc_fail);
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_btree_node_free);
> -
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_btree_gc_coalesce);
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_gc_start);
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_gc_end);
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_gc_copy);
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_gc_copy_collision);
> -
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_btree_insert_key);
> -
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_btree_node_split);
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_btree_node_compact);
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_btree_set_root);
> -
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_invalidate);
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_alloc_fail);
> -
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_writeback);
> -EXPORT_TRACEPOINT_SYMBOL_GPL(bcache_writeback_collision);
> --
> 2.30.2
>
prev parent reply other threads:[~2022-12-02 9:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-01 6:32 [PATCH] bcache: don't export tracepoints Christoph Hellwig
2022-12-01 6:51 ` Coly Li
2022-12-02 9:52 ` Coly Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E6C67F90-D2B7-4D43-8289-162A0C627B00@suse.de \
--to=colyli@suse.de \
--cc=hch@lst.de \
--cc=linux-bcache@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).