From: Dave Kleikamp <dave.kleikamp@oracle.com>
To: Anton Altaparmakov <anton@tuxera.com>, Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Coly Li <colyli@suse.de>,
Mike Snitzer <snitzer@redhat.com>, Song Liu <song@kernel.org>,
David Sterba <dsterba@suse.com>,
Josef Bacik <josef@toxicpanda.com>, Theodore Ts'o <tytso@mit.edu>,
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
Ryusuke Konishi <konishi.ryusuke@gmail.com>,
Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
Kees Cook <keescook@chromium.org>,
Phillip Lougher <phillip@squashfs.org.uk>,
Jan Kara <jack@suse.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
"drbd-dev@lists.linbit.com" <drbd-dev@lists.linbit.com>,
"linux-bcache@vger.kernel.org" <linux-bcache@vger.kernel.org>,
"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"jfs-discussion@lists.sourceforge.net"
<jfs-discussion@lists.sourceforge.net>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"linux-nilfs@vger.kernel.org" <linux-nilfs@vger.kernel.org>,
"linux-ntfs-dev@lists.sourceforge.net"
<linux-ntfs-dev@lists.sourceforge.net>,
"ntfs3@lists.linux.dev" <ntfs3@lists.linux.dev>,
"reiserfs-devel@vger.kernel.org" <reiserfs-devel@vger.kernel.org>
Subject: Re: don't use ->bd_inode to access the block device size
Date: Thu, 14 Oct 2021 08:13:59 -0500 [thread overview]
Message-ID: <a5eb3c18-deb2-6539-cc24-57e6d5d3500c@oracle.com> (raw)
In-Reply-To: <3AB8052D-DD45-478B-85F2-BFBEC1C7E9DF@tuxera.com>
On 10/14/21 4:32AM, Anton Altaparmakov wrote:
> Hi Christoph,
>
>> On 14 Oct 2021, at 07:28, Christoph Hellwig <hch@lst.de> wrote:
>>
>> On Wed, Oct 13, 2021 at 07:10:13AM +0200, Christoph Hellwig wrote:
>>> I wondered about adding a helper for looking at the size in byte units
>>> to avoid the SECTOR_SHIFT shifts in various places. But given that
>>> I could not come up with a good name and block devices fundamentally
>>> work in sector size granularity I decided against that.
>>
>> So it seems like the biggest review feedback is that we should have
>> such a helper. I think the bdev_size name is the worst as size does
>> not imply a particular unit. bdev_nr_bytes is a little better but I'm
>> not too happy. Any other suggestions or strong opinions?
>
> bdev_byte_size() would seem to address your concerns?
>
> bdev_nr_bytes() would work though - it is analogous to bdev_nr_sectors() after all.
>
> No strong opinion here but I do agree with you that bdev_size() is a bad choice for sure. It is bound to cause bugs down the line when people forget what unit it is in.
I don't really mind bdev_size since it's analogous to i_size, but
bdev_nr_bytes seems good to me.
Shaggy
> Best regards,
>
> Anton
>
next prev parent reply other threads:[~2021-10-14 13:15 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 5:10 don't use ->bd_inode to access the block device size Christoph Hellwig
2021-10-13 5:10 ` [PATCH 01/29] bcache: remove bdev_sectors Christoph Hellwig
2021-10-13 5:21 ` Coly Li
2021-10-13 6:09 ` Kees Cook
2021-10-13 5:10 ` [PATCH 02/29] drbd: use bdev_nr_sectors instead of open coding it Christoph Hellwig
2021-10-13 6:09 ` Kees Cook
2021-10-13 22:33 ` Chaitanya Kulkarni
2021-10-13 5:10 ` [PATCH 03/29] dm: " Christoph Hellwig
2021-10-13 6:10 ` Kees Cook
2021-10-13 16:43 ` Mike Snitzer
2021-10-13 5:10 ` [PATCH 04/29] md: " Christoph Hellwig
2021-10-13 6:12 ` Kees Cook
2021-10-13 21:14 ` Song Liu
2021-10-13 5:10 ` [PATCH 05/29] mtd/block2mtd: " Christoph Hellwig
2021-10-13 5:10 ` [PATCH 06/29] nvmet: " Christoph Hellwig
2021-10-13 22:33 ` Chaitanya Kulkarni
2021-10-13 5:10 ` [PATCH 07/29] target/iblock: " Christoph Hellwig
2021-10-13 9:31 ` Bodo Stroesser
2021-10-13 22:37 ` Chaitanya Kulkarni
2021-10-13 5:10 ` [PATCH 08/29] fs: use bdev_nr_sectors instead of open coding it in blkdev_max_block Christoph Hellwig
2021-10-13 10:42 ` Jan Kara
2021-10-13 22:35 ` Chaitanya Kulkarni
2021-10-13 5:10 ` [PATCH 09/29] fs: simplify init_page_buffers Christoph Hellwig
2021-10-13 6:14 ` Kees Cook
2021-10-13 10:42 ` Jan Kara
2021-10-13 5:10 ` [PATCH 10/29] affs: use bdev_nr_sectors instead of open coding it Christoph Hellwig
2021-10-13 6:14 ` Kees Cook
2021-10-13 5:10 ` [PATCH 11/29] btrfs: " Christoph Hellwig
2021-10-13 7:08 ` Anand Jain
2021-10-13 22:36 ` Chaitanya Kulkarni
2021-10-14 2:44 ` Keith Busch
2021-10-13 5:10 ` [PATCH 12/29] cramfs: " Christoph Hellwig
2021-10-13 6:16 ` Kees Cook
2021-10-13 5:10 ` [PATCH 13/29] fat: " Christoph Hellwig
2021-10-13 6:16 ` Kees Cook
2021-10-13 5:10 ` [PATCH 14/29] hfs: " Christoph Hellwig
2021-10-13 6:16 ` Kees Cook
2021-10-13 5:10 ` [PATCH 15/29] hfsplus: " Christoph Hellwig
2021-10-13 6:16 ` Kees Cook
2021-10-13 5:10 ` [PATCH 16/29] jfs: " Christoph Hellwig
2021-10-13 14:13 ` Dave Kleikamp
2021-10-13 5:10 ` [PATCH 17/29] nfs/blocklayout: " Christoph Hellwig
2021-10-13 5:10 ` [PATCH 18/29] nilfs2: " Christoph Hellwig
2021-10-13 5:10 ` [PATCH 19/29] ntfs3: " Christoph Hellwig
2021-10-13 5:10 ` [PATCH 20/29] pstore/blk: " Christoph Hellwig
2021-10-13 5:10 ` [PATCH 21/29] reiserfs: " Christoph Hellwig
2021-10-13 10:43 ` Jan Kara
2021-10-13 5:10 ` [PATCH 22/29] squashfs: " Christoph Hellwig
2021-10-13 19:37 ` Phillip Lougher
2021-10-13 5:10 ` [PATCH 23/29] block: use bdev_nr_sectors instead of open coding it in blkdev_fallocate Christoph Hellwig
2021-10-13 10:44 ` Jan Kara
2021-10-13 22:34 ` Chaitanya Kulkarni
2021-10-13 5:10 ` [PATCH 24/29] block: add a sb_bdev_nr_blocks helper Christoph Hellwig
2021-10-13 6:27 ` Kees Cook
2021-10-13 5:10 ` [PATCH 25/29] ext4: use sb_bdev_nr_blocks Christoph Hellwig
2021-10-13 6:29 ` Kees Cook
2021-10-13 6:30 ` Kees Cook
2021-10-13 10:46 ` Jan Kara
2021-10-13 15:51 ` Theodore Ts'o
2021-10-13 5:10 ` [PATCH 26/29] jfs: " Christoph Hellwig
2021-10-13 6:31 ` Kees Cook
2021-10-13 5:10 ` [PATCH 27/29] ntfs: " Christoph Hellwig
2021-10-13 6:33 ` Kees Cook
2021-10-13 5:10 ` [PATCH 28/29] reiserfs: " Christoph Hellwig
2021-10-13 6:33 ` Kees Cook
2021-10-13 10:46 ` Jan Kara
2021-10-13 5:10 ` [PATCH 29/29] udf: " Christoph Hellwig
2021-10-13 6:34 ` Kees Cook
2021-10-13 10:47 ` Jan Kara
2021-10-13 6:39 ` don't use ->bd_inode to access the block device size Kees Cook
2021-10-13 7:14 ` Anand Jain
2021-10-14 6:28 ` Christoph Hellwig
2021-10-14 9:32 ` Anton Altaparmakov
2021-10-14 13:13 ` Dave Kleikamp [this message]
2021-10-14 15:14 ` Kees Cook
2021-10-14 15:35 ` Wol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5eb3c18-deb2-6539-cc24-57e6d5d3500c@oracle.com \
--to=dave.kleikamp@oracle.com \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=anton@tuxera.com \
--cc=axboe@kernel.dk \
--cc=colyli@suse.de \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=dsterba@suse.com \
--cc=hch@lst.de \
--cc=hirofumi@mail.parknet.co.jp \
--cc=jack@suse.com \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=josef@toxicpanda.com \
--cc=keescook@chromium.org \
--cc=konishi.ryusuke@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
--cc=phillip@squashfs.org.uk \
--cc=reiserfs-devel@vger.kernel.org \
--cc=snitzer@redhat.com \
--cc=song@kernel.org \
--cc=target-devel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).