linux-bcache.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] bcache: add BLK_DEV dependency for BCACHE_NVM_PAGES
@ 2021-04-21 13:50 Arnd Bergmann
  2021-04-21 14:17 ` Randy Dunlap
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2021-04-21 13:50 UTC (permalink / raw)
  To: Coly Li, Kent Overstreet, Jens Axboe, Jianpeng Ma
  Cc: Arnd Bergmann, Jean Delvare, linux-bcache, linux-kernel

From: Arnd Bergmann <arnd@arndb.de>

Selecting this without CONFIG_BLK_DEV causes a Kconfig warning:

WARNING: unmet direct dependencies detected for LIBNVDIMM
  Depends on [n]: PHYS_ADDR_T_64BIT [=y] && HAS_IOMEM [=y] && BLK_DEV [=n]
  Selected by [y]:
  - BCACHE_NVM_PAGES [=y] && MD [=y] && BCACHE [=y] && PHYS_ADDR_T_64BIT [=y]

Add it as another dependency.

Fixes: 688330711e9a ("bcache: initialize the nvm pages allocator")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/md/bcache/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/md/bcache/Kconfig b/drivers/md/bcache/Kconfig
index 0996e366ad0b..9cb3d8c39fc1 100644
--- a/drivers/md/bcache/Kconfig
+++ b/drivers/md/bcache/Kconfig
@@ -40,6 +40,7 @@ config BCACHE_NVM_PAGES
 	bool "NVDIMM support for bcache (EXPERIMENTAL)"
 	depends on BCACHE
 	depends on PHYS_ADDR_T_64BIT
+	depends on BLKDEV
 	select LIBNVDIMM
 	select DAX
 	help
-- 
2.29.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] bcache: add BLK_DEV dependency for BCACHE_NVM_PAGES
  2021-04-21 13:50 [PATCH] bcache: add BLK_DEV dependency for BCACHE_NVM_PAGES Arnd Bergmann
@ 2021-04-21 14:17 ` Randy Dunlap
  0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2021-04-21 14:17 UTC (permalink / raw)
  To: Arnd Bergmann, Coly Li, Kent Overstreet, Jens Axboe, Jianpeng Ma
  Cc: Arnd Bergmann, Jean Delvare, linux-bcache, linux-kernel

On 4/21/21 6:50 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Selecting this without CONFIG_BLK_DEV causes a Kconfig warning:
> 
> WARNING: unmet direct dependencies detected for LIBNVDIMM
>   Depends on [n]: PHYS_ADDR_T_64BIT [=y] && HAS_IOMEM [=y] && BLK_DEV [=n]
>   Selected by [y]:
>   - BCACHE_NVM_PAGES [=y] && MD [=y] && BCACHE [=y] && PHYS_ADDR_T_64BIT [=y]
> 
> Add it as another dependency.
> 
> Fixes: 688330711e9a ("bcache: initialize the nvm pages allocator")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/md/bcache/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/md/bcache/Kconfig b/drivers/md/bcache/Kconfig
> index 0996e366ad0b..9cb3d8c39fc1 100644
> --- a/drivers/md/bcache/Kconfig
> +++ b/drivers/md/bcache/Kconfig
> @@ -40,6 +40,7 @@ config BCACHE_NVM_PAGES
>  	bool "NVDIMM support for bcache (EXPERIMENTAL)"
>  	depends on BCACHE
>  	depends on PHYS_ADDR_T_64BIT
> +	depends on BLKDEV

	           BLK_DEV

>  	select LIBNVDIMM
>  	select DAX
>  	help
> 

tested?

-- 
~Randy


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-21 14:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-21 13:50 [PATCH] bcache: add BLK_DEV dependency for BCACHE_NVM_PAGES Arnd Bergmann
2021-04-21 14:17 ` Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).