linux-bcache.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] bcache: remove unused struct member in cache_stats
@ 2021-10-29 11:59 Lin Feng
  2021-10-30 14:58 ` Coly Li
  0 siblings, 1 reply; 2+ messages in thread
From: Lin Feng @ 2021-10-29 11:59 UTC (permalink / raw)
  To: colyli, ent.overstreet; +Cc: linux-bcache, linux-kernel, linf

Commit 1616a4c2ab1a80893b6890ae93da40a2b1d0c691
("bcache: remove bcache device self-defined readahead")
remove stuffs for bcache self-defined readahead, but
cache_readaheads field in cache_stats is leftout, remove it.

Signed-off-by: Lin Feng <linf@wangsu.com>
---
 drivers/md/bcache/stats.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/md/bcache/stats.h b/drivers/md/bcache/stats.h
index ca4f435f7216..b6bfea66c01f 100644
--- a/drivers/md/bcache/stats.h
+++ b/drivers/md/bcache/stats.h
@@ -18,7 +18,6 @@ struct cache_stats {
 	unsigned long cache_misses;
 	unsigned long cache_bypass_hits;
 	unsigned long cache_bypass_misses;
-	unsigned long cache_readaheads;
 	unsigned long cache_miss_collisions;
 	unsigned long sectors_bypassed;
 
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] bcache: remove unused struct member in cache_stats
  2021-10-29 11:59 [PATCH] bcache: remove unused struct member in cache_stats Lin Feng
@ 2021-10-30 14:58 ` Coly Li
  0 siblings, 0 replies; 2+ messages in thread
From: Coly Li @ 2021-10-30 14:58 UTC (permalink / raw)
  To: Lin Feng; +Cc: linux-bcache, linux-kernel

On 10/29/21 7:59 PM, Lin Feng wrote:
> Commit 1616a4c2ab1a80893b6890ae93da40a2b1d0c691
> ("bcache: remove bcache device self-defined readahead")
> remove stuffs for bcache self-defined readahead, but
> cache_readaheads field in cache_stats is leftout, remove it.
>
> Signed-off-by: Lin Feng <linf@wangsu.com>

Nice catch. I add it into my testing queue. Thanks.

Coly Li

> ---
>   drivers/md/bcache/stats.h | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/md/bcache/stats.h b/drivers/md/bcache/stats.h
> index ca4f435f7216..b6bfea66c01f 100644
> --- a/drivers/md/bcache/stats.h
> +++ b/drivers/md/bcache/stats.h
> @@ -18,7 +18,6 @@ struct cache_stats {
>   	unsigned long cache_misses;
>   	unsigned long cache_bypass_hits;
>   	unsigned long cache_bypass_misses;
> -	unsigned long cache_readaheads;
>   	unsigned long cache_miss_collisions;
>   	unsigned long sectors_bypassed;
>   


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-30 14:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-29 11:59 [PATCH] bcache: remove unused struct member in cache_stats Lin Feng
2021-10-30 14:58 ` Coly Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).