Linux-bcache Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] bcache: writeback: Remove unneeded variable i
@ 2020-07-09  5:53 Xu Wang
  2020-07-09  5:53 ` Xu Wang
  2020-07-09  6:04 ` Coly Li
  0 siblings, 2 replies; 3+ messages in thread
From: Xu Wang @ 2020-07-09  5:53 UTC (permalink / raw)
  To: colyli, kent.overstreet, linux-bcache; +Cc: linux-kernel, Xu Wang

Remove unneeded variable i in bch_dirty_init_thread().

Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
 drivers/md/bcache/writeback.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/md/bcache/writeback.c b/drivers/md/bcache/writeback.c
index 1cf1e5016cb9..71801c086b82 100644
--- a/drivers/md/bcache/writeback.c
+++ b/drivers/md/bcache/writeback.c
@@ -825,10 +825,8 @@ static int bch_dirty_init_thread(void *arg)
 	struct btree_iter iter;
 	struct bkey *k, *p;
 	int cur_idx, prev_idx, skip_nr;
-	int i;
 
 	k = p = NULL;
-	i = 0;
 	cur_idx = prev_idx = 0;
 
 	bch_btree_iter_init(&c->root->keys, &iter, NULL);
-- 
2.17.1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] bcache: writeback: Remove unneeded variable i
  2020-07-09  5:53 [PATCH] bcache: writeback: Remove unneeded variable i Xu Wang
@ 2020-07-09  5:53 ` Xu Wang
  2020-07-09  6:04 ` Coly Li
  1 sibling, 0 replies; 3+ messages in thread
From: Xu Wang @ 2020-07-09  5:53 UTC (permalink / raw)
  To: colyli, kent.overstreet, linux-bcache; +Cc: linux-kernel, Xu Wang

Remove unneeded variable i in bch_dirty_init_thread().

Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
 drivers/md/bcache/writeback.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/md/bcache/writeback.c b/drivers/md/bcache/writeback.c
index 1cf1e5016cb9..71801c086b82 100644
--- a/drivers/md/bcache/writeback.c
+++ b/drivers/md/bcache/writeback.c
@@ -825,10 +825,8 @@ static int bch_dirty_init_thread(void *arg)
 	struct btree_iter iter;
 	struct bkey *k, *p;
 	int cur_idx, prev_idx, skip_nr;
-	int i;
 
 	k = p = NULL;
-	i = 0;
 	cur_idx = prev_idx = 0;
 
 	bch_btree_iter_init(&c->root->keys, &iter, NULL);
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] bcache: writeback: Remove unneeded variable i
  2020-07-09  5:53 [PATCH] bcache: writeback: Remove unneeded variable i Xu Wang
  2020-07-09  5:53 ` Xu Wang
@ 2020-07-09  6:04 ` Coly Li
  1 sibling, 0 replies; 3+ messages in thread
From: Coly Li @ 2020-07-09  6:04 UTC (permalink / raw)
  To: Xu Wang; +Cc: kent.overstreet, linux-bcache, linux-kernel

On 2020/7/9 13:53, Xu Wang wrote:
> Remove unneeded variable i in bch_dirty_init_thread().
> 
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>

Add it into my testing queue. Thanks.

Coly Li

> ---
>  drivers/md/bcache/writeback.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/md/bcache/writeback.c b/drivers/md/bcache/writeback.c
> index 1cf1e5016cb9..71801c086b82 100644
> --- a/drivers/md/bcache/writeback.c
> +++ b/drivers/md/bcache/writeback.c
> @@ -825,10 +825,8 @@ static int bch_dirty_init_thread(void *arg)
>  	struct btree_iter iter;
>  	struct bkey *k, *p;
>  	int cur_idx, prev_idx, skip_nr;
> -	int i;
>  
>  	k = p = NULL;
> -	i = 0;
>  	cur_idx = prev_idx = 0;
>  
>  	bch_btree_iter_init(&c->root->keys, &iter, NULL);
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-09  5:53 [PATCH] bcache: writeback: Remove unneeded variable i Xu Wang
2020-07-09  5:53 ` Xu Wang
2020-07-09  6:04 ` Coly Li

Linux-bcache Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-bcache/0 linux-bcache/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-bcache linux-bcache/ https://lore.kernel.org/linux-bcache \
		linux-bcache@vger.kernel.org
	public-inbox-index linux-bcache

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-bcache


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git