From: "Thomas Weißschuh" <thomas@t-8ch.de>
To: Kent Overstreet <kent.overstreet@linux.dev>
Cc: linux-bcache@vger.kernel.org, linux-bcachefs@vger.kernel.org
Subject: Re: bcachefs-tools: O_DIRECT necessary?
Date: Mon, 31 Oct 2022 04:10:12 +0100 [thread overview]
Message-ID: <bb3fa56a-7fa2-4920-98a2-6768845ef6cd@t-8ch.de> (raw)
In-Reply-To: <20221031014000.hgohrfv7t4dpraia@moria.home.lan>
On 2022-10-30 21:41-0400, Kent Overstreet wrote:
> On Mon, Oct 31, 2022 at 02:18:40AM +0100, Thomas Weißschuh wrote:
> > Hi all,
> >
> > I just tried to run the unittests of bcachefs-tools and they are failing for
> > me.
> > The culprit is that mkfs.bcachefs tries to open the disk image with O_DIRECT
> > which is not allowed on tmpfs.
> >
> > Is O_DIRECT really necessary for mkfs? It does not seem necessary for other
> > filesystems.
>
> Hey - the proper mailing list for bcachefs is linux-bcachefs@vger.kernel.org now
> :)
My bad, I copied the wrong list from one of your mails.
> It's not strictly necessary, we use O_DIRECT because we're emulating the kernel
> bio interface. There are other situations where this has been a problem though,
> we need to add either a flag to use buffered IO or preferably a way to
> automatically fall back to buffered IO.
>
> Could you open a bug for this? I'll try to get to it in the near future
>
> https://github.com/koverstreet/bcachefs/issues/
I opened it in the tools repo because those are broken:
https://github.com/koverstreet/bcachefs-tools/issues/132
Thomas
prev parent reply other threads:[~2022-10-31 3:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 1:18 bcachefs-tools: O_DIRECT necessary? Thomas Weißschuh
2022-10-31 1:41 ` Kent Overstreet
2022-10-31 3:10 ` Thomas Weißschuh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb3fa56a-7fa2-4920-98a2-6768845ef6cd@t-8ch.de \
--to=thomas@t-8ch.de \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-bcachefs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).