From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94775C47082 for ; Sun, 23 May 2021 07:46:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A7F36115C for ; Sun, 23 May 2021 07:46:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231648AbhEWHrc (ORCPT ); Sun, 23 May 2021 03:47:32 -0400 Received: from mx2.suse.de ([195.135.220.15]:40030 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231591AbhEWHrb (ORCPT ); Sun, 23 May 2021 03:47:31 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1621755963; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qgeGl97uX/ASq/b1LiyPvGm5KNHhtUs0K8R0hHcKHNc=; b=loXc3McbnIlaTeOmap5xh/BtT1gA18JtYlPnnRT16wqHGfTJ19lzfYOvtfB0oOgoXJJBVk /ReVtyQfx/H7rkQyR4p+DdQCpRAZIyorp+zG3qS0QxK3kt3astNHDmaxUpril0ODq2rDNt r9Vkt/28bb7h7z+3O1fywe0kQCnoBFg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1621755963; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qgeGl97uX/ASq/b1LiyPvGm5KNHhtUs0K8R0hHcKHNc=; b=ColirDJTDltQ04gjJ+NwT5obDqeCRv1j+ud81TmJU8SNYoFAHUoSAb2/6qAn8/xG4ncH3n i/HOh7UwzHlRZeDg== Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id AF152AB5F; Sun, 23 May 2021 07:46:03 +0000 (UTC) Subject: Re: [PATCH 01/26] block: refactor device number setup in __device_add_disk To: Christoph Hellwig , Jens Axboe , Geert Uytterhoeven , Chris Zankel , Max Filippov , Philipp Reisner , Lars Ellenberg , Jim Paris , Joshua Morris , Philip Kelleher , Minchan Kim , Nitin Gupta , Matias Bjorling , Coly Li , Mike Snitzer , Song Liu , Maxim Levitsky , Alex Dubov , Ulf Hansson , Dan Williams , Vishal Verma , Dave Jiang , Heiko Carstens , Vasily Gorbik , Christian Borntraeger Cc: linux-block@vger.kernel.org, dm-devel@redhat.com, linux-m68k@lists.linux-m68k.org, linux-xtensa@linux-xtensa.org, drbd-dev@lists.linbit.com, linuxppc-dev@lists.ozlabs.org, linux-bcache@vger.kernel.org, linux-raid@vger.kernel.org, linux-mmc@vger.kernel.org, nvdimm@lists.linux.dev, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org References: <20210521055116.1053587-1-hch@lst.de> <20210521055116.1053587-2-hch@lst.de> From: Hannes Reinecke Message-ID: Date: Sun, 23 May 2021 09:46:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210521055116.1053587-2-hch@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org On 5/21/21 7:50 AM, Christoph Hellwig wrote: > Untangle the mess around blk_alloc_devt by moving the check for > the used allocation scheme into the callers. > > Signed-off-by: Christoph Hellwig > --- > block/blk.h | 4 +- > block/genhd.c | 96 ++++++++++++++++------------------------- > block/partitions/core.c | 15 +++++-- > 3 files changed, 49 insertions(+), 66 deletions(-) > ... and also fixes an issue with GENHD_FL_UP remained set in an error path in __device_add_disk(). Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer