From: Coly Li <colyli@suse.de>
To: Qing Wang <wangqing@vivo.com>
Cc: Kent Overstreet <kent.overstreet@gmail.com>,
linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] bcache: replace snprintf in show functions with sysfs_emit
Date: Mon, 18 Oct 2021 22:47:00 +0800 [thread overview]
Message-ID: <f63d7139-8843-793a-dfb8-b368e57ce425@suse.de> (raw)
In-Reply-To: <1634126301-2849-1-git-send-email-wangqing@vivo.com>
On 10/13/21 7:58 PM, Qing Wang wrote:
> coccicheck complains about the use of snprintf() in sysfs show functions.
>
> Fix the following coccicheck warning:
> drivers/md/bcache/sysfs.h:54:12-20: WARNING: use scnprintf or sprintf.
>
> Implement sysfs_print() by sysfs_emit() and remove snprint() since no one
> uses it any more.
>
> Suggested-by: Coly Li <colyli@suse.de>
> Signed-off-by: Qing Wang <wangqing@vivo.com>
It looks fine to me. Let me add it into my for-test directory.
Thanks for the fix up.
Coly Li
> ---
> drivers/md/bcache/sysfs.h | 18 ++++++++++++++++--
> drivers/md/bcache/util.h | 17 -----------------
> 2 files changed, 16 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/md/bcache/sysfs.h b/drivers/md/bcache/sysfs.h
> index 215df32..c1752ba
> --- a/drivers/md/bcache/sysfs.h
> +++ b/drivers/md/bcache/sysfs.h
> @@ -51,13 +51,27 @@ STORE(fn) \
> #define sysfs_printf(file, fmt, ...) \
> do { \
> if (attr == &sysfs_ ## file) \
> - return snprintf(buf, PAGE_SIZE, fmt "\n", __VA_ARGS__); \
> + return sysfs_emit(buf, fmt "\n", __VA_ARGS__); \
> } while (0)
>
> #define sysfs_print(file, var) \
> do { \
> if (attr == &sysfs_ ## file) \
> - return snprint(buf, PAGE_SIZE, var); \
> + return sysfs_emit(buf, \
> + __builtin_types_compatible_p(typeof(var), int) \
> + ? "%i\n" : \
> + __builtin_types_compatible_p(typeof(var), unsigned int) \
> + ? "%u\n" : \
> + __builtin_types_compatible_p(typeof(var), long) \
> + ? "%li\n" : \
> + __builtin_types_compatible_p(typeof(var), unsigned long)\
> + ? "%lu\n" : \
> + __builtin_types_compatible_p(typeof(var), int64_t) \
> + ? "%lli\n" : \
> + __builtin_types_compatible_p(typeof(var), uint64_t) \
> + ? "%llu\n" : \
> + __builtin_types_compatible_p(typeof(var), const char *) \
> + ? "%s\n" : "%i\n", var); \
> } while (0)
>
> #define sysfs_hprint(file, val) \
> diff --git a/drivers/md/bcache/util.h b/drivers/md/bcache/util.h
> index b64460a..fecdea1
> --- a/drivers/md/bcache/util.h
> +++ b/drivers/md/bcache/util.h
> @@ -340,23 +340,6 @@ static inline int bch_strtoul_h(const char *cp, long *res)
> _r; \
> })
>
> -#define snprint(buf, size, var) \
> - snprintf(buf, size, \
> - __builtin_types_compatible_p(typeof(var), int) \
> - ? "%i\n" : \
> - __builtin_types_compatible_p(typeof(var), unsigned int) \
> - ? "%u\n" : \
> - __builtin_types_compatible_p(typeof(var), long) \
> - ? "%li\n" : \
> - __builtin_types_compatible_p(typeof(var), unsigned long)\
> - ? "%lu\n" : \
> - __builtin_types_compatible_p(typeof(var), int64_t) \
> - ? "%lli\n" : \
> - __builtin_types_compatible_p(typeof(var), uint64_t) \
> - ? "%llu\n" : \
> - __builtin_types_compatible_p(typeof(var), const char *) \
> - ? "%s\n" : "%i\n", var)
> -
> ssize_t bch_hprint(char *buf, int64_t v);
>
> bool bch_is_zero(const char *p, size_t n);
prev parent reply other threads:[~2021-10-18 14:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 11:58 [PATCH V2] bcache: replace snprintf in show functions with sysfs_emit Qing Wang
2021-10-18 14:47 ` Coly Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f63d7139-8843-793a-dfb8-b368e57ce425@suse.de \
--to=colyli@suse.de \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangqing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).