From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-176.mta1.migadu.com (out-176.mta1.migadu.com [95.215.58.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FE424645F for ; Mon, 22 Jan 2024 17:42:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705945350; cv=none; b=bpVcQPhpZrn7u4Yp6pVkbgdFe0e6AXSVQ573F1QNX9igX4HYyBQ7Ggb/IwBZ73lCQFJrVTyjuFwU8JGxWjXswsGkn5+aWIGupw3f8/gxGtpF7aihq8zgpuzV9Qcc5vmsMyZvZMg2bvF1TRRja4IjPgTG2GXNjoy9yX5zHZkxGBw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705945350; c=relaxed/simple; bh=gj9qLw1tQ84HJlkMwWSeCO447oh/wRG2lRtRfaFUyIw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sGVh7VPHUGiPhBvJBr7BYeaGIc0OV7cx5wboGzbOl4DCXWBspKkzx64lqgtq7haTI9As2XUsbVFkJFT10Rs44ULGHe6hRUiN19cZgrLAhOnFdTa52dMDpgvVTgElKvoMF37gQA6u0zGQTQr6Tk389r7gQyIbgrqc8OmdN0jvjDQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=UQvIBgEc; arc=none smtp.client-ip=95.215.58.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="UQvIBgEc" Date: Mon, 22 Jan 2024 12:42:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1705945346; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7ty78UTcDEPkGWAbT8QZy4zXIuGDbN0PS7GrkuXlRwQ=; b=UQvIBgEcr5vKCrm143csud8eE+w8mU0A+pLQYk2jtsynfCESs2crcq3Dr5jdATlvF6bTvT 3tIdqDKNG81O0GYX4QV+0k9xggdw/CkMvsnfemP6vJXsewzosX3u9AMBPTT28Nt7j0JqLP 3L4poLtDohvR0fBbNjP5AhsI3fYEYWg= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Christoph Hellwig Cc: bfoster@redhat.com, linux-bcachefs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] bcachefs: fix incorrect usage of REQ_OP_FLUSH Message-ID: <6jhgnewkmex25jgtw2s3fifyyje4w3yja2exdrnx2vesk6bp5w@gysfpght3cbo> References: <20240111073655.2095423-1-hch@lst.de> <20240122063007.GA23991@lst.de> <20240122065038.GA24601@lst.de> <3cs7zhkf3gz7fmytpxqjvstr6oegvhy3ehwu3mzomfllvjqlmc@yaq6ophbgbfr> <20240122173809.GA5676@lst.de> Precedence: bulk X-Mailing-List: linux-bcachefs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240122173809.GA5676@lst.de> X-Migadu-Flow: FLOW_OUT On Mon, Jan 22, 2024 at 06:38:09PM +0100, Christoph Hellwig wrote: > On Mon, Jan 22, 2024 at 12:37:10PM -0500, Kent Overstreet wrote: > > Ahh - I misread the bug report (fedora puts out kernels before rc1!?). > > Thanks, your patch is back in :) > > Please throw it in your test setup and watch the results carefully. > I'm pretty sure it is correct, but I do not actually have a way to > verify it right now. updating my tests for the MD_FAULTY removal, then will do. Is there anything you want me to look for? considering most tests won't break or won't clearly break if flush/fua is being dropped (even generic/388 was passing reliably, of course, since virtual block devices aren't going to reorder writes...) maybe we could do some print statement sanity checking...