From: Kent Overstreet <kent.overstreet@gmail.com>
To: Eryu Guan <eguan@linux.alibaba.com>
Cc: fstests@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-bcachefs@vger.kernel.org
Subject: Re: [PATCH 3/3] Use --yes option to lvcreate
Date: Tue, 27 Apr 2021 16:29:23 -0400 [thread overview]
Message-ID: <YIh0Iy+BiY4zzhB1@moria.home.lan> (raw)
In-Reply-To: <20210427170339.GA9611@e18g06458.et15sqa>
On Wed, Apr 28, 2021 at 01:03:39AM +0800, Eryu Guan wrote:
> On Tue, Apr 27, 2021 at 12:44:19PM -0400, Kent Overstreet wrote:
> > This fixes spurious test failures caused by broken pipe messages.
> >
> > Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
> > ---
> > tests/generic/081 | 2 +-
> > tests/generic/108 | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/generic/081 b/tests/generic/081
> > index 5dff079852..26702007ab 100755
> > --- a/tests/generic/081
> > +++ b/tests/generic/081
> > @@ -70,7 +70,7 @@ _scratch_mkfs_sized $((300 * 1024 * 1024)) >>$seqres.full 2>&1
> > $LVM_PROG vgcreate -f $vgname $SCRATCH_DEV >>$seqres.full 2>&1
> > # We use yes pipe instead of 'lvcreate --yes' because old version of lvm
> > # (like 2.02.95 in RHEL6) don't support --yes option
> > -yes | $LVM_PROG lvcreate -L 256M -n $lvname $vgname >>$seqres.full 2>&1
> > +$LVM_PROG lvcreate --yes -L 256M -n $lvname $vgname >>$seqres.full 2>&1
>
> Please see above comments, we use yes pipe intentionally. I don't see
> how this would result in broken pipe. Would you please provide more
> details? And let's see if we could fix the broken pipe issue.
If lvcreate never ask y/n - never reads from standard input, then echo sees a
broken pipe when it tries to write. That's what I get without this patch.
next prev parent reply other threads:[~2021-04-27 20:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 16:44 [PATCH 0/3] bcachefs support Kent Overstreet
2021-04-27 16:44 ` [PATCH 1/3] Initial " Kent Overstreet
2021-05-09 14:36 ` Eryu Guan
2021-05-23 22:51 ` Kent Overstreet
2021-05-24 3:56 ` Eryu Guan
2021-05-24 4:04 ` Kent Overstreet
2021-05-24 4:22 ` Eryu Guan
2021-05-24 4:48 ` Kent Overstreet
2021-04-27 16:44 ` [PATCH 2/3] Improved .gitignore Kent Overstreet
2021-04-27 16:44 ` [PATCH 3/3] Use --yes option to lvcreate Kent Overstreet
2021-04-27 17:03 ` Eryu Guan
2021-04-27 20:29 ` Kent Overstreet [this message]
2021-04-27 20:43 ` Matthew Wilcox
2021-04-27 21:02 ` Eric Biggers
2021-04-27 21:18 ` Kent Overstreet
2021-05-09 14:20 ` [PATCH 0/3] bcachefs support Eryu Guan
2021-05-10 23:14 ` Dave Chinner
2021-05-11 1:26 ` Darrick J. Wong
2021-05-16 13:54 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YIh0Iy+BiY4zzhB1@moria.home.lan \
--to=kent.overstreet@gmail.com \
--cc=eguan@linux.alibaba.com \
--cc=fstests@vger.kernel.org \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).