From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC491C77B7C for ; Fri, 26 May 2023 08:34:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242719AbjEZIeU (ORCPT ); Fri, 26 May 2023 04:34:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236981AbjEZIeT (ORCPT ); Fri, 26 May 2023 04:34:19 -0400 Received: from out-63.mta0.migadu.com (out-63.mta0.migadu.com [IPv6:2001:41d0:1004:224b::3f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27566D9 for ; Fri, 26 May 2023 01:34:18 -0700 (PDT) Date: Fri, 26 May 2023 04:34:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1685090056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a1+k8geEgB3EI42+JJ+lx1nGKMJgJ9cIZX0cMtf11v8=; b=YmHfcSlC6Hj1py8HMz8oTzzq+ZfEqeBn9Pz/Ed/IQtvrF6RfexPzvh/A/8AYkicbAz78LB o9z8e2ts1pjbylZmZNsPRSHfTV8H+Il0z8tQSYR9//uxbgsPVnS9Fvo4aqt9a7iMtin30f oNKadLj96+v5lfZsEVRpmAnphhg6I7Y= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Kent Overstreet To: Christoph Hellwig Cc: Jan Kara , cluster-devel@redhat.com, "Darrick J . Wong" , linux-kernel@vger.kernel.org, dhowells@redhat.com, linux-bcachefs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Kent Overstreet Subject: Re: [Cluster-devel] [PATCH 06/32] sched: Add task_struct->faults_disabled_mapping Message-ID: References: <20230510010737.heniyuxazlprrbd6@quack3> <20230523133431.wwrkjtptu6vqqh5e@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-bcachefs@vger.kernel.org On Fri, May 26, 2023 at 01:06:46AM -0700, Christoph Hellwig wrote: > On Thu, May 25, 2023 at 04:50:39PM -0400, Kent Overstreet wrote: > > A cache that isn't actually consistent is a _bug_. You're being > > Obsequious. And any time this has come up in previous discussions > > (including at LSF), that was never up for debate, the only question has > > been whether it was even possible to practically fix it. > > That is not my impression. But again, if you think it is useful, > go ahead and seel people on the idea. But please prepare a series > that includes the rationale, performance tradeoffs and real live > implications for it. And do it on the existing code that people use > and not just your shiny new thing. When I'm ready to lift this to the VFS level I will; it should simplify locking overall and it'll be one less thing for people to worry about. (i.e. the fact that even _readahead_ can pull in pages a dio is invalidating is a really nice footgun if not worked around). Right now though I've got more than enough on my plate just trying to finally get bcachefs merged, I'm happy to explain what this is for but I'm not ready for additional headaches or projects yet.