From: Calum Mackay <calum.mackay@oracle.com>
To: John Hubbard <jhubbard@nvidia.com>,
john.hubbard@gmail.com, Andrew Morton <akpm@linux-foundation.org>
Cc: calum.mackay@oracle.com, "Christoph Hellwig" <hch@infradead.org>,
"Dan Williams" <dan.j.williams@intel.com>,
"Dave Chinner" <david@fromorbit.com>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"Ira Weiny" <ira.weiny@intel.com>, "Jan Kara" <jack@suse.cz>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Jérôme Glisse" <jglisse@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
amd-gfx@lists.freedesktop.org, ceph-devel@vger.kernel.org,
devel@driverdev.osuosl.org, devel@lists.orangefs.org,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-block@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-fbdev@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-media@vger.kernel.org, linux-mm@kvack.org,
linux-nfs@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org, linux-xfs@vger.kernel.org,
netdev@vger.kernel.org, rds-devel@oss.oracle.com,
sparclinux@vger.kernel.org, x86@kernel.org,
xen-devel@lists.xenproject.org,
"Trond Myklebust" <trond.myklebust@hammerspace.com>,
"Anna Schumaker" <anna.schumaker@netapp.com>
Subject: Re: [PATCH 31/34] nfs: convert put_page() to put_user_page*()
Date: Mon, 5 Aug 2019 00:28:01 +0100 [thread overview]
Message-ID: <03a81556-98a7-7edb-5989-b799ec99a072@oracle.com> (raw)
In-Reply-To: <db136399-ed87-56ea-bd6e-e5d29b145eda@nvidia.com>
On 03/08/2019 2:41 am, John Hubbard wrote:
> On 8/2/19 6:27 PM, Calum Mackay wrote:
>> On 02/08/2019 3:20 am, john.hubbard@gmail.com wrote:
> ...
>> Since it's static, and only called twice, might it be better to change its two callers [nfs_direct_{read,write}_schedule_iovec()] to call put_user_pages() directly, and remove nfs_direct_release_pages() entirely?
>>
>> thanks,
>> calum.
>>
>>
>>> void nfs_init_cinfo_from_dreq(struct nfs_commit_info *cinfo,
>>>
>
> Hi Calum,
>
> Absolutely! Is it OK to add your reviewed-by, with the following incremental
> patch made to this one?
Thanks John; looks good.
Reviewed-by: Calum Mackay <calum.mackay@oracle.com>
>
> diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c
> index b00b89dda3c5..c0c1b9f2c069 100644
> --- a/fs/nfs/direct.c
> +++ b/fs/nfs/direct.c
> @@ -276,11 +276,6 @@ ssize_t nfs_direct_IO(struct kiocb *iocb, struct iov_iter *iter)
> return nfs_file_direct_write(iocb, iter);
> }
>
> -static void nfs_direct_release_pages(struct page **pages, unsigned int npages)
> -{
> - put_user_pages(pages, npages);
> -}
> -
> void nfs_init_cinfo_from_dreq(struct nfs_commit_info *cinfo,
> struct nfs_direct_req *dreq)
> {
> @@ -510,7 +505,7 @@ static ssize_t nfs_direct_read_schedule_iovec(struct nfs_direct_req *dreq,
> pos += req_len;
> dreq->bytes_left -= req_len;
> }
> - nfs_direct_release_pages(pagevec, npages);
> + put_user_pages(pagevec, npages);
> kvfree(pagevec);
> if (result < 0)
> break;
> @@ -933,7 +928,7 @@ static ssize_t nfs_direct_write_schedule_iovec(struct nfs_direct_req *dreq,
> pos += req_len;
> dreq->bytes_left -= req_len;
> }
> - nfs_direct_release_pages(pagevec, npages);
> + put_user_pages(pagevec, npages);
> kvfree(pagevec);
> if (result < 0)
> break;
>
>
>
> thanks,
>
next prev parent reply other threads:[~2019-08-04 23:29 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 2:19 [PATCH 00/34] put_user_pages(): miscellaneous call sites john.hubbard
2019-08-02 2:19 ` [PATCH 01/34] mm/gup: add make_dirty arg to put_user_pages_dirty_lock() john.hubbard
2019-08-02 2:19 ` [PATCH 02/34] net/rds: convert put_page() to put_user_page*() john.hubbard
2019-08-02 2:19 ` [PATCH 03/34] net/ceph: " john.hubbard
2019-08-02 22:32 ` Jeff Layton
2019-08-02 2:19 ` [PATCH 04/34] x86/kvm: " john.hubbard
2019-08-02 2:19 ` [PATCH 05/34] drm/etnaviv: convert release_pages() to put_user_pages() john.hubbard
2019-08-02 2:19 ` [PATCH 06/34] drm/i915: convert put_page() to put_user_page*() john.hubbard
2019-08-02 9:19 ` Joonas Lahtinen
2019-08-02 18:48 ` John Hubbard
2019-08-03 20:03 ` John Hubbard
2019-08-02 2:19 ` [PATCH 07/34] drm/radeon: " john.hubbard
2019-08-02 2:19 ` [PATCH 08/34] media/ivtv: " john.hubbard
2019-08-02 2:19 ` [PATCH 09/34] media/v4l2-core/mm: " john.hubbard
2019-08-02 2:19 ` [PATCH 10/34] genwqe: " john.hubbard
2019-08-03 7:06 ` Greg Kroah-Hartman
2019-08-02 2:19 ` [PATCH 11/34] scif: " john.hubbard
2019-08-02 2:19 ` [PATCH 12/34] vmci: " john.hubbard
2019-08-02 2:19 ` [PATCH 13/34] rapidio: " john.hubbard
2019-08-02 2:19 ` [PATCH 14/34] oradax: " john.hubbard
2019-08-02 2:19 ` [PATCH 15/34] staging/vc04_services: " john.hubbard
2019-08-03 7:06 ` Greg Kroah-Hartman
2019-08-02 2:19 ` [PATCH 16/34] drivers/tee: " john.hubbard
2019-08-02 6:29 ` Jens Wiklander
2019-08-02 18:51 ` John Hubbard
2019-08-02 2:19 ` [PATCH 17/34] vfio: " john.hubbard
2019-08-02 2:19 ` [PATCH 18/34] fbdev/pvr2fb: " john.hubbard
2019-08-02 2:19 ` [PATCH 19/34] fsl_hypervisor: " john.hubbard
2019-08-02 2:19 ` [PATCH 20/34] xen: " john.hubbard
2019-08-02 4:36 ` Juergen Gross
2019-08-02 5:48 ` John Hubbard
2019-08-02 6:10 ` Juergen Gross
2019-08-02 16:09 ` Weiny, Ira
2019-08-02 19:25 ` John Hubbard
2019-08-02 2:19 ` [PATCH 21/34] fs/exec.c: " john.hubbard
2019-08-02 2:19 ` [PATCH 22/34] orangefs: " john.hubbard
2019-08-02 2:19 ` [PATCH 23/34] uprobes: " john.hubbard
2019-08-02 2:19 ` [PATCH 24/34] futex: " john.hubbard
2019-08-02 2:19 ` [PATCH 25/34] mm/frame_vector.c: " john.hubbard
2019-08-02 2:19 ` [PATCH 26/34] mm/gup_benchmark.c: " john.hubbard
2019-08-02 14:19 ` Keith Busch
2019-08-02 2:19 ` [PATCH 27/34] mm/memory.c: " john.hubbard
2019-08-02 2:19 ` [PATCH 28/34] mm/madvise.c: " john.hubbard
2019-08-02 2:20 ` [PATCH 29/34] mm/process_vm_access.c: " john.hubbard
2019-08-02 2:20 ` [PATCH 30/34] crypt: " john.hubbard
2019-08-02 2:20 ` [PATCH 31/34] nfs: " john.hubbard
2019-08-03 1:27 ` Calum Mackay
2019-08-03 1:41 ` John Hubbard
2019-08-04 23:28 ` Calum Mackay [this message]
2019-08-02 2:20 ` [PATCH 32/34] goldfish_pipe: " john.hubbard
2019-08-02 2:20 ` [PATCH 33/34] kernel/events/core.c: " john.hubbard
2019-08-02 2:20 ` [PATCH 34/34] fs/binfmt_elf: " john.hubbard
2019-08-02 9:12 ` [PATCH 00/34] put_user_pages(): miscellaneous call sites Michal Hocko
2019-08-02 12:41 ` Jan Kara
2019-08-02 14:24 ` Matthew Wilcox
2019-08-02 14:52 ` Jan Kara
2019-08-02 19:14 ` John Hubbard
2019-08-07 8:37 ` Jan Kara
2019-08-07 8:46 ` Michal Hocko
2019-08-08 2:36 ` Ira Weiny
2019-08-08 3:46 ` John Hubbard
2019-08-08 16:25 ` Weiny, Ira
2019-08-08 18:18 ` John Hubbard
2019-08-09 8:34 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03a81556-98a7-7edb-5989-b799ec99a072@oracle.com \
--to=calum.mackay@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=anna.schumaker@netapp.com \
--cc=ceph-devel@vger.kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@fromorbit.com \
--cc=devel@driverdev.osuosl.org \
--cc=devel@lists.orangefs.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@infradead.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=john.hubbard@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=sparclinux@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).