Linux-Block Archive on lore.kernel.org
 help / color / Atom feed
* Re: linux-next: Tree for Apr 19 (bcache)
       [not found] <20210419202309.0575ad77@canb.auug.org.au>
@ 2021-04-19 15:40 ` Randy Dunlap
  2021-04-19 16:26   ` Coly Li
  0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2021-04-19 15:40 UTC (permalink / raw)
  To: Stephen Rothwell, Linux Next Mailing List
  Cc: Linux Kernel Mailing List, linux-block, linux-bcache, Coly Li,
	Kent Overstreet


[-- Attachment #1: Type: text/plain, Size: 462 bytes --]

On 4/19/21 3:23 AM, Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20210416:
> 

on x86_64:

when
# CONFIG_BLK_DEV is not set


WARNING: unmet direct dependencies detected for LIBNVDIMM
  Depends on [n]: PHYS_ADDR_T_64BIT [=y] && HAS_IOMEM [=y] && BLK_DEV [=n]
  Selected by [y]:
  - BCACHE_NVM_PAGES [=y] && MD [=y] && BCACHE [=y] && PHYS_ADDR_T_64BIT [=y]


Full randconfig file is attached.

-- 
~Randy
Reported-by: Randy Dunlap <rdunlap@infradead.org>

[-- Attachment #2: config-r8861.gz --]
[-- Type: application/gzip, Size: 34259 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: linux-next: Tree for Apr 19 (bcache)
  2021-04-19 15:40 ` linux-next: Tree for Apr 19 (bcache) Randy Dunlap
@ 2021-04-19 16:26   ` Coly Li
  2021-04-19 17:50     ` Jens Axboe
  0 siblings, 1 reply; 4+ messages in thread
From: Coly Li @ 2021-04-19 16:26 UTC (permalink / raw)
  To: Randy Dunlap, Stephen Rothwell, Linux Next Mailing List
  Cc: Linux Kernel Mailing List, linux-block, linux-bcache, Kent Overstreet

On 4/19/21 11:40 PM, Randy Dunlap wrote:
> On 4/19/21 3:23 AM, Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20210416:
>>
> 
> on x86_64:
> 
> when
> # CONFIG_BLK_DEV is not set
> 
> 
> WARNING: unmet direct dependencies detected for LIBNVDIMM
>   Depends on [n]: PHYS_ADDR_T_64BIT [=y] && HAS_IOMEM [=y] && BLK_DEV [=n]
>   Selected by [y]:
>   - BCACHE_NVM_PAGES [=y] && MD [=y] && BCACHE [=y] && PHYS_ADDR_T_64BIT [=y]
> 
> 
> Full randconfig file is attached.
> 

I need hint from kbuild expert.

My original idea to use "select LIBNVDIMM" is to avoid the
BCACHE_NVM_PAGES option to disappear if LIBNVDIMM is not enabled.
Otherwise if nvdimm driver is not configure, users won't know there is a
BCACHE_NVM_PAGES option unless they read bcache Kconfig file.

But I see nvdimm's Kconfig, it uses "depends on BLK_DEV", I understand
it is acceptable that LIBNVDIMM option to disappear from "make
menuconfig" if BLK_DEV is not enabled.

For such condition, which one is the proper way to set the dependence ?
- Change "select LIBNVDIMM" and "select DAX" to "depends on LIBNVDIMM"
and "depends on DAX" in bcache Kconfig
- Or change "depends on BLK_DEV" to "select BLK_DEV" in nvdimm Kconfig.


I want to ask for a proper way to handle such dependence, and I will
follow the guide for now and in future.

Thanks in advance for the advice.

Coly Li

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: linux-next: Tree for Apr 19 (bcache)
  2021-04-19 16:26   ` Coly Li
@ 2021-04-19 17:50     ` Jens Axboe
  2021-04-20  4:24       ` Coly Li
  0 siblings, 1 reply; 4+ messages in thread
From: Jens Axboe @ 2021-04-19 17:50 UTC (permalink / raw)
  To: Coly Li, Randy Dunlap, Stephen Rothwell, Linux Next Mailing List
  Cc: Linux Kernel Mailing List, linux-block, linux-bcache, Kent Overstreet

On 4/19/21 10:26 AM, Coly Li wrote:
> On 4/19/21 11:40 PM, Randy Dunlap wrote:
>> On 4/19/21 3:23 AM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> Changes since 20210416:
>>>
>>
>> on x86_64:
>>
>> when
>> # CONFIG_BLK_DEV is not set
>>
>>
>> WARNING: unmet direct dependencies detected for LIBNVDIMM
>>   Depends on [n]: PHYS_ADDR_T_64BIT [=y] && HAS_IOMEM [=y] && BLK_DEV [=n]
>>   Selected by [y]:
>>   - BCACHE_NVM_PAGES [=y] && MD [=y] && BCACHE [=y] && PHYS_ADDR_T_64BIT [=y]
>>
>>
>> Full randconfig file is attached.
>>
> 
> I need hint from kbuild expert.
> 
> My original idea to use "select LIBNVDIMM" is to avoid the
> BCACHE_NVM_PAGES option to disappear if LIBNVDIMM is not enabled.
> Otherwise if nvdimm driver is not configure, users won't know there is a
> BCACHE_NVM_PAGES option unless they read bcache Kconfig file.

But why? That's exactly how it should work. Just use depends to set the
dependency.

> But I see nvdimm's Kconfig, it uses "depends on BLK_DEV", I understand
> it is acceptable that LIBNVDIMM option to disappear from "make
> menuconfig" if BLK_DEV is not enabled.
> 
> For such condition, which one is the proper way to set the dependence ?
> - Change "select LIBNVDIMM" and "select DAX" to "depends on LIBNVDIMM"
> and "depends on DAX" in bcache Kconfig
> - Or change "depends on BLK_DEV" to "select BLK_DEV" in nvdimm Kconfig.

The former.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: linux-next: Tree for Apr 19 (bcache)
  2021-04-19 17:50     ` Jens Axboe
@ 2021-04-20  4:24       ` Coly Li
  0 siblings, 0 replies; 4+ messages in thread
From: Coly Li @ 2021-04-20  4:24 UTC (permalink / raw)
  To: Jens Axboe
  Cc: Linux Kernel Mailing List, linux-block, linux-bcache,
	Kent Overstreet, Stephen Rothwell, Linux Next Mailing List,
	Randy Dunlap

On 4/20/21 1:50 AM, Jens Axboe wrote:
> On 4/19/21 10:26 AM, Coly Li wrote:
>> On 4/19/21 11:40 PM, Randy Dunlap wrote:
>>> On 4/19/21 3:23 AM, Stephen Rothwell wrote:
>>>> Hi all,
>>>>
>>>> Changes since 20210416:
>>>>
>>>
>>> on x86_64:
>>>
>>> when
>>> # CONFIG_BLK_DEV is not set
>>>
>>>
>>> WARNING: unmet direct dependencies detected for LIBNVDIMM
>>>   Depends on [n]: PHYS_ADDR_T_64BIT [=y] && HAS_IOMEM [=y] && BLK_DEV [=n]
>>>   Selected by [y]:
>>>   - BCACHE_NVM_PAGES [=y] && MD [=y] && BCACHE [=y] && PHYS_ADDR_T_64BIT [=y]
>>>
>>>
>>> Full randconfig file is attached.
>>>
>>
>> I need hint from kbuild expert.
>>
>> My original idea to use "select LIBNVDIMM" is to avoid the
>> BCACHE_NVM_PAGES option to disappear if LIBNVDIMM is not enabled.
>> Otherwise if nvdimm driver is not configure, users won't know there is a
>> BCACHE_NVM_PAGES option unless they read bcache Kconfig file.
> 
> But why? That's exactly how it should work. Just use depends to set the
> dependency.
> 
>> But I see nvdimm's Kconfig, it uses "depends on BLK_DEV", I understand
>> it is acceptable that LIBNVDIMM option to disappear from "make
>> menuconfig" if BLK_DEV is not enabled.
>>
>> For such condition, which one is the proper way to set the dependence ?
>> - Change "select LIBNVDIMM" and "select DAX" to "depends on LIBNVDIMM"
>> and "depends on DAX" in bcache Kconfig
>> - Or change "depends on BLK_DEV" to "select BLK_DEV" in nvdimm Kconfig.
> 
> The former.
> 

Copied. Thanks for the hint. I will post a fix soon.

Coly Li

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20210419202309.0575ad77@canb.auug.org.au>
2021-04-19 15:40 ` linux-next: Tree for Apr 19 (bcache) Randy Dunlap
2021-04-19 16:26   ` Coly Li
2021-04-19 17:50     ` Jens Axboe
2021-04-20  4:24       ` Coly Li

Linux-Block Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-block/0 linux-block/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-block linux-block/ https://lore.kernel.org/linux-block \
		linux-block@vger.kernel.org
	public-inbox-index linux-block

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-block


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git