From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 009B2C433ED for ; Fri, 9 Apr 2021 13:04:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC57A610FC for ; Fri, 9 Apr 2021 13:04:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232615AbhDINEf (ORCPT ); Fri, 9 Apr 2021 09:04:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231946AbhDINEe (ORCPT ); Fri, 9 Apr 2021 09:04:34 -0400 Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FC52C061760; Fri, 9 Apr 2021 06:04:20 -0700 (PDT) Received: by mail-ot1-x329.google.com with SMTP id w31-20020a9d36220000b02901f2cbfc9743so5586554otb.7; Fri, 09 Apr 2021 06:04:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bkC7oh7EgtxDZTJqabD79gqBuCSSsyNkTwSg5S2YKA8=; b=hbnX00rFQAOsrF4vzYmebE9x47VSQdMMYuJY3fKnqwC4mBW8hxYlDkQ3ClTvk7AEbf 9s8Y5Bp563eJuS6whbRkJVPNUmnn154MuxNnmebBYQqWYFOZ9p/hANVBDaUsex68mEw5 5w/4iycWYRYFqBljcREVZxkT8VaWusmdK9gIXLkYtALJcQQQBemBYmRzJkRGVi1WzR9O 5hp2ag3gxV8arq3wgVq/QoSVOsprmjuN3wWYXAdZipbHqk8onVDzfMjeAWlAGwb75hkN mycMJ+LAEv8HO1XT+JDRcdxLopbAPBONueo3BYSArepGQHROP1dli9832xkgAJHQ+jzb i/Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=bkC7oh7EgtxDZTJqabD79gqBuCSSsyNkTwSg5S2YKA8=; b=XkRinTu4NIdfxwDFDJdlZdpYBxSpzWAff3K4xjvTiUi1RCg0ZJoQJOcSRsp0YDiMdD Y/4ctTcCqlgz+P5F7stVNhf+/4gsWMgHkvx08sIoJYo6I/yfYbmZI/T450CQbA/rFRTJ NnNjfGZE62BmYxG3jXCLmLDTBNpwEyYf635TuvkaHNa49K1n2TuzE/H7czlGvbRUPDh+ EIffbDdi/7L/2c0cM0Q38ygfhd/C+7MusXFhqGTgULWc8C0SI7DfX6gQooa17aLplbyT QJdyNVUeCMfGn5sKlZsQtIqdH3qMMMATXJtQh3IChSqGpZU4By8HkumhaiiU7HmJUy48 OcdQ== X-Gm-Message-State: AOAM531b0/pNteNr/yjrAXVT146jwr0xbYs5WNd8WA1s6XeiRJH76BFz SGZDlo3arQIQ/Ut+LkV1A0k= X-Google-Smtp-Source: ABdhPJxm18X9BElp9EPhnmEC3wmYo+XNi9NK6DaXNCtqjW0TQx/FcXWkQRgymvm3A4Ko6ID3skouhw== X-Received: by 2002:a9d:4808:: with SMTP id c8mr12344379otf.181.1617973459290; Fri, 09 Apr 2021 06:04:19 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id 64sm503511oob.12.2021.04.09.06.04.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Apr 2021 06:04:18 -0700 (PDT) Sender: Guenter Roeck Subject: Re: [PATCH 8/8] block: stop calling blk_queue_bounce for passthrough requests To: Christoph Hellwig Cc: Jens Axboe , Khalid Aziz , "Martin K. Petersen" , Matthew Wilcox , Hannes Reinecke , Ondrej Zary , linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, Hannes Reinecke References: <20210331073001.46776-1-hch@lst.de> <20210331073001.46776-9-hch@lst.de> <20210408214506.GA184625@roeck-us.net> <20210409074034.GA5636@lst.de> From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= Message-ID: <09cb9786-37d2-f23f-dbe4-1c2d45f29668@roeck-us.net> Date: Fri, 9 Apr 2021 06:04:16 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210409074034.GA5636@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On 4/9/21 12:40 AM, Christoph Hellwig wrote: > On Thu, Apr 08, 2021 at 02:45:06PM -0700, Guenter Roeck wrote: >> On Wed, Mar 31, 2021 at 09:30:01AM +0200, Christoph Hellwig wrote: >>> Instead of overloading the passthrough fast path with the deprecated >>> block layer bounce buffering let the users that combine an old >>> undermaintained driver with a highmem system pay the price by always >>> falling back to copies in that case. >>> >> >> Hmm, that price is pretty high. When trying to boot sh images from usb, >> it results in a traceback, followed by an i/o error, and the drive >> fails to open. > > That's just because this warning is completely bogus, sorry. > > Does this patch fix the boot for you? > Yes it does. Tested-by: Guenter Roeck Thanks, Guenter > diff --git a/block/blk-map.c b/block/blk-map.c > index dac78376acc899..3743158ddaeb76 100644 > --- a/block/blk-map.c > +++ b/block/blk-map.c > @@ -485,9 +485,6 @@ int blk_rq_append_bio(struct request *rq, struct bio *bio) > struct bio_vec bv; > unsigned int nr_segs = 0; > > - if (WARN_ON_ONCE(rq->q->limits.bounce != BLK_BOUNCE_NONE)) > - return -EINVAL; > - > bio_for_each_bvec(bv, bio, iter) > nr_segs++; > >