From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74318C55178 for ; Fri, 30 Oct 2020 01:23:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 21E7220731 for ; Fri, 30 Oct 2020 01:23:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725372AbgJ3BX2 (ORCPT ); Thu, 29 Oct 2020 21:23:28 -0400 Received: from smtprelay0213.hostedemail.com ([216.40.44.213]:52318 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725379AbgJ3BX1 (ORCPT ); Thu, 29 Oct 2020 21:23:27 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id A389A18029210; Fri, 30 Oct 2020 01:23:25 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: teeth17_541127c27292 X-Filterd-Recvd-Size: 2939 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf11.hostedemail.com (Postfix) with ESMTPA; Fri, 30 Oct 2020 01:23:22 +0000 (UTC) Message-ID: <0b286566394d2e65cf3977ce3a76c6bbc18cb947.camel@perches.com> Subject: Re: [PATCH] z2ram: MODULE_LICENSE update and neatening From: Joe Perches To: James Bottomley , Christoph Hellwig , Jens Axboe Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Denis Efremov , "David S. Miller" , Song Liu , Al Viro , Finn Thain , Michael Schmitz , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, linux-raid@vger.kernel.org, linux-scsi@vger.kernel.org, linux-m68k@lists.linux-m68k.org, Hannes Reinecke Date: Thu, 29 Oct 2020 18:23:21 -0700 In-Reply-To: <202d1246a14617e4e7a4a7b723dc92191815d134.camel@HansenPartnership.com> References: <20201029145841.144173-1-hch@lst.de> <20201029145841.144173-18-hch@lst.de> <4945b720d67e9f67b8c8ba02a29c6af1ffa15b08.camel@perches.com> <202d1246a14617e4e7a4a7b723dc92191815d134.camel@HansenPartnership.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Thu, 2020-10-29 at 18:01 -0700, James Bottomley wrote: > On Thu, 2020-10-29 at 17:11 -0700, Joe Perches wrote: > > This file still does not have an SPDX line. What should it be? > > It's old style MIT with a slight variation: > > https://fedoraproject.org/wiki/Licensing:MIT#Old_Style Yes, it's quite similar. But ", and sell" does not exist in this variant. So I believe its use of MODULE_LICENSE("GPL") is not correct and that MODULE_LICENSE("GPL and additional rights") might be the best available option. MIT Old style: Permission to use, copy, modify, distribute, and sell this software and its documentation for any purpose is hereby granted without fee, provided that the above copyright notice appear in all copies and that both that copyright notice and this permission notice appear in supporting documentation. No representations are made about the suitability of this software for any purpose. It is provided "as is" without express or implied warranty. License in the file: * Permission to use, copy, modify, and distribute this software and its * documentation for any purpose and without fee is hereby granted, provided * that the above copyright notice appear in all copies and that both that * copyright notice and this permission notice appear in supporting * documentation. This software is provided "as is" without express or * implied warranty.