From: Logan Gunthorpe <logang@deltatee.com>
To: Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
Omar Sandoval <osandov@osandov.com>
Cc: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH v3 2/7] nvme: consolidate some nvme-cli utility functions
Date: Wed, 12 Aug 2020 09:49:04 -0600 [thread overview]
Message-ID: <0bd39633-b0b9-1e56-dd5e-514285842ebd@deltatee.com> (raw)
In-Reply-To: <20200811210102.194287-3-sagi@grimberg.me>
On 2020-08-11 3:00 p.m., Sagi Grimberg wrote:
> diff --git a/tests/nvme/rc b/tests/nvme/rc
> index 320aa4b2b475..6d57cf591300 100644
> --- a/tests/nvme/rc
> +++ b/tests/nvme/rc
> @@ -64,7 +64,7 @@ _cleanup_nvmet() {
> transport="$(cat "/sys/class/nvme/${dev}/transport")"
> if [[ "$transport" == "loop" ]]; then
> echo "WARNING: Test did not clean up loop device: ${dev}"
> - nvme disconnect -d "${dev}"
> + _nvme_disconnect_ctrl "${dev}"
> fi
> done
>
> @@ -97,6 +97,33 @@ _setup_nvmet() {
> modprobe nvme-loop
> }
>
> +_nvme_disconnect_ctrl() {
> + local ctrl="$1"
> +
> + nvme disconnect -d ${ctrl}
We're missing some quotes here and in many other places in this
patchset. Have you run shellcheck on this? I'd expect it to complain
about these.
> +}
> +
> +_nvme_disconnect_subsys() {
> + local subsysnqn="$1"
> +
> + nvme disconnect -n ${subsysnqn}
> +}
> +
> +_nvme_connect_subsys() {
> + local trtype="$1"
> + local subsysnqn="$2"
> +
> + cmd="nvme connect -t ${trtype} -n ${subsysnqn}"
> + eval $cmd
Why eval? It makes the quoting here questionable...
Logan
next prev parent reply other threads:[~2020-08-12 15:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 21:00 [PATCH v3 0/7] blktests: Add support to run nvme tests with tcp/rdma transports Sagi Grimberg
2020-08-11 21:00 ` [PATCH v3 1/7] nvme: consolidate nvme requirements based on transport type Sagi Grimberg
2020-08-13 2:44 ` Chaitanya Kulkarni
2020-08-11 21:00 ` [PATCH v3 2/7] nvme: consolidate some nvme-cli utility functions Sagi Grimberg
2020-08-12 15:49 ` Logan Gunthorpe [this message]
2020-08-11 21:00 ` [PATCH v3 3/7] nvme: make tests transport type agnostic Sagi Grimberg
2020-08-11 21:00 ` [PATCH v3 4/7] tests/nvme: restrict tests to specific transports Sagi Grimberg
2020-08-11 21:01 ` [PATCH v3 5/7] nvme: support nvme-tcp when runinng tests Sagi Grimberg
2020-08-13 2:42 ` Chaitanya Kulkarni
2020-08-11 21:01 ` [PATCH v3 6/7] common: move module_unload to common Sagi Grimberg
2020-08-11 21:30 ` Bart Van Assche
2020-08-11 21:45 ` Sagi Grimberg
2020-08-11 21:01 ` [PATCH v3 7/7] nvme: support rdma transport type Sagi Grimberg
2020-08-13 11:01 ` [PATCH v3 0/7] blktests: Add support to run nvme tests with tcp/rdma transports Yi Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bd39633-b0b9-1e56-dd5e-514285842ebd@deltatee.com \
--to=logang@deltatee.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=osandov@osandov.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).