linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [GIT PULL] Floppy patch for 5.15
@ 2021-08-29 10:08 Denis Efremov
  2021-08-29 12:52 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Denis Efremov @ 2021-08-29 10:08 UTC (permalink / raw)
  To: Jens Axboe; +Cc: linux-block, Linux-kernel

Hi Jens,

Sorry for the late PR this time. I'll resend it later if it's too late for
your for-5.15/drivers branch. Thanks.

The following changes since commit 461d971215dfb55bcd5f7d040b2b222592040f95:

  Merge branch 'md-next' of https://git.kernel.org/pub/scm/linux/kernel/git/song/md into for-5.15/drivers (2021-08-27 16:32:01 -0600)

are available in the Git repository at:

  https://github.com/evdenis/linux-floppy tags/floppy-for-5.15

for you to fetch changes up to c7e9d0020361f4308a70cdfd6d5335e273eb8717:

  Revert "floppy: reintroduce O_NDELAY fix" (2021-08-28 11:16:47 +0300)

Please, pull

----------------------------------------------------------------
Bring back O_NDELAY for floppy

Only one commit this time with revert of O_NDELAY removal for the floppy.
Users reported that the commit breaks userspace utils and known floppy
workflow patterns. We already reverted the same commit back in 2016
presumably for the same reason. Completely drop O_NDELAY for floppy seems
excessive to solve problems it introduces.

I started to write basic selftests for the floppy to prevent this kind of
userspace breaks in the future.

Signed-off-by: Denis Efremov <efremov@linux.com>

----------------------------------------------------------------
Denis Efremov (1):
      Revert "floppy: reintroduce O_NDELAY fix"

 drivers/block/floppy.c | 30 +++++++++++++++---------------
 1 file changed, 15 insertions(+), 15 deletions(-)

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [GIT PULL] Floppy patch for 5.15
  2021-08-29 10:08 [GIT PULL] Floppy patch for 5.15 Denis Efremov
@ 2021-08-29 12:52 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2021-08-29 12:52 UTC (permalink / raw)
  To: Denis Efremov; +Cc: linux-block, Linux-kernel

On 8/29/21 4:08 AM, Denis Efremov wrote:
> Hi Jens,
> 
> Sorry for the late PR this time. I'll resend it later if it's too late for
> your for-5.15/drivers branch. Thanks.

Given the patch in question, let's just do it. I've pulled it, thanks.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-29 12:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-29 10:08 [GIT PULL] Floppy patch for 5.15 Denis Efremov
2021-08-29 12:52 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).