From: Jens Axboe <axboe@kernel.dk>
To: Damien Le Moal <damien.lemoal@wdc.com>, linux-block@vger.kernel.org
Cc: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
Kanchan Joshi <joshi.k@samsung.com>
Subject: Re: [PATCH 0/2] zoned null_blk fixes
Date: Thu, 29 Oct 2020 07:27:41 -0600 [thread overview]
Message-ID: <0dff7464-c7f8-9ce1-7946-cc8896e5e2c5@kernel.dk> (raw)
In-Reply-To: <20201029110500.803451-1-damien.lemoal@wdc.com>
On 10/29/20 5:04 AM, Damien Le Moal wrote:
> Jens,
>
> Here is a couple of fixes for nullblk for this cycle.
>
> The first patch fixes tracing of zone condition in the case of a
> REQ_OP_ZONE_RESET_ALL operation.
>
> The second patch fixes a more serious problem introduced with the recent
> modification for protecting zone information using a spinlock. A
> spinlock cannot be used when memory backing is turned on as that results
> in potential memory allocations with the lock held and IRQ disabled.
> The fix changes the locking method to using a bit, with the spinlock
> retained only for function local protection. This new locking was
> extensively tested with xfstests/btrfs and zonefs tests runs.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2020-10-29 13:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 11:04 [PATCH 0/2] zoned null_blk fixes Damien Le Moal
2020-10-29 11:04 ` [PATCH 1/2] null_blk: Fix zone reset all tracing Damien Le Moal
2020-10-29 11:05 ` [PATCH 2/2] null_blk: Fix locking in zoned mode Damien Le Moal
2020-10-29 13:27 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dff7464-c7f8-9ce1-7946-cc8896e5e2c5@kernel.dk \
--to=axboe@kernel.dk \
--cc=chaitanya.kulkarni@wdc.com \
--cc=damien.lemoal@wdc.com \
--cc=joshi.k@samsung.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).