Linux-Block Archive on
 help / color / Atom feed
From: Jens Axboe <>
To: Jeff Moyer <>
Subject: Re: [PATCHSET v2] io_uring: support fileset add/remove/modify
Date: Fri, 4 Oct 2019 12:52:03 -0600
Message-ID: <> (raw)
In-Reply-To: <>

On 10/4/19 12:17 PM, Jeff Moyer wrote:
> Jens Axboe <> writes:
>> Currently we only support registrering a fixed file set. If changes need
>> to be made to that set, the application must unregister the existing set
>> first, then register a new one.
>> This patchset adds support for sparse file sets (patch 1), which means
>> the application can register a fileset with room for expansion. This is
>> done through having unregistered slots use fd == -1.
>> On top of that, we can add IORING_REGISTER_FILES_UPDATE. This allows
>> modifying the existing file set through:
>> - Replacing empty slots with valid file descriptors
>> - Replacing valid descriptors with an empty slot
>> - Modifying an existing slot, replacing a file descriptor with a new one
> I don't pretend to understand the socket code you wrote.  The io_uring
> bits look good to me.  I also added a testcase to your file-register.c
> program--diff below.  The test passes, of course.  :)

Great, thanks Jeff, I'll add this to the test case.

Jens Axboe

      reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-04 16:22 Jens Axboe
2019-10-04 16:22 ` [PATCH 1/2] io_uring: allow sparse fixed file sets Jens Axboe
2019-10-04 16:22 ` [PATCH 2/2] io_uring: add support for IORING_REGISTER_FILES_UPDATE Jens Axboe
2019-10-04 18:17 ` [PATCHSET v2] io_uring: support fileset add/remove/modify Jeff Moyer
2019-10-04 18:52   ` Jens Axboe [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Block Archive on

Archives are clonable:
	git clone --mirror linux-block/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-block linux-block/ \
	public-inbox-index linux-block

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone