From: David Howells <dhowells@redhat.com>
To: Hugh Dickins <hughd@google.com>
Cc: dhowells@redhat.com, Jens Axboe <axboe@kernel.dk>,
Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <willy@infradead.org>,
Naoya Horiguchi <naoya.horiguchi@nec.com>,
David Hildenbrand <david@redhat.com>,
Yang Shi <shy828301@gmail.com>,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH next] shmem: minor fixes to splice-read implementation
Date: Mon, 17 Apr 2023 08:18:57 +0100 [thread overview]
Message-ID: <1379675.1681715937@warthog.procyon.org.uk> (raw)
In-Reply-To: <2d5fa5e3-dac5-6973-74e5-eeedf36a42b@google.com>
Hugh Dickins <hughd@google.com> wrote:
> + if (unlikely(!len))
> + return 0;
Should this be done in do_splice_to() instead?
Also, is it too late for Jens to fold this into the original patch since it's
not upstream yet?
Otherwise:
Reviewed-by: David Howells <dhowells@redhat.com>
next prev parent reply other threads:[~2023-04-17 7:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-17 4:46 [PATCH next] shmem: minor fixes to splice-read implementation Hugh Dickins
2023-04-17 7:18 ` David Howells [this message]
2023-04-17 11:21 ` David Hildenbrand
2023-04-17 13:48 ` Jens Axboe
2023-06-29 4:42 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379675.1681715937@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=david@redhat.com \
--cc=hughd@google.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
--cc=shy828301@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).