From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Bart Van Assche To: "hch@lst.de" , Damien Le Moal CC: "linux-scsi@vger.kernel.org" , "hare@suse.de" , "linux-block@vger.kernel.org" , "MPT-FusionLinux.pdl@broadcom.com" , "martin.petersen@oracle.com" , "axboe@kernel.dk" Subject: Re: [PATCH 0/3] Separate zone requests from medium access requests Date: Tue, 28 Feb 2017 16:16:46 +0000 Message-ID: <1488298588.2370.1.camel@sandisk.com> References: <20170228102535.15966-1-damien.lemoal@wdc.com> <20170228160259.GA22755@lst.de> In-Reply-To: <20170228160259.GA22755@lst.de> Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Return-Path: Bart.VanAssche@sandisk.com List-ID: On Tue, 2017-02-28 at 17:02 +0100, Christoph Hellwig wrote: > I don't really like this too much - this is too many SCSI specifics > for the block layer to care. Maybe using bios for the zone ops was a > mistake after all, and we should just have operations in struct block_dev= ice > instead.. blk_rq_accesses_medium() has nothing to do with SCSI. It is a reintroductio= n of what REQ_TYPE_FS stood for before ZBC was introduced but with another na= me. BTW, I think that all blk_rq_is_passthrough() callers have to be reviewed t= o see whether or not !blk_rq_accesses_medium() is perhaps what was intended. Bart.=