From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0FEEC433FE for ; Tue, 14 Dec 2021 17:57:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236773AbhLNR5y (ORCPT ); Tue, 14 Dec 2021 12:57:54 -0500 Received: from smtp03.smtpout.orange.fr ([80.12.242.125]:53364 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236535AbhLNR5x (ORCPT ); Tue, 14 Dec 2021 12:57:53 -0500 Received: from [192.168.1.18] ([86.243.171.122]) by smtp.orange.fr with ESMTPA id xC3hmDtUWIEdlxC3hmHzWx; Tue, 14 Dec 2021 18:57:51 +0100 X-ME-Helo: [192.168.1.18] X-ME-Auth: YWZlNiIxYWMyZDliZWIzOTcwYTEyYzlhMmU3ZiQ1M2U2MzfzZDfyZTMxZTBkMTYyNDBjNDJlZmQ3ZQ== X-ME-Date: Tue, 14 Dec 2021 18:57:51 +0100 X-ME-IP: 86.243.171.122 Subject: Re: [PATCH v2] xen-blkfront: Use the bitmap API when applicable To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org, axboe@kernel.dk, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Newsgroups: gmane.linux.kernel.janitors,gmane.comp.emulators.xen.devel,gmane.linux.block,gmane.linux.kernel References: From: Christophe JAILLET Message-ID: <14dbcf69-afc1-c11b-e1ad-e8453a80cc6e@wanadoo.fr> Date: Tue, 14 Dec 2021 18:57:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org Le 14/12/2021 à 12:08, Roger Pau Monné a écrit : > On Tue, Dec 14, 2021 at 11:59:39AM +0100, Roger Pau Monné wrote: >> On Thu, Dec 02, 2021 at 09:16:04PM +0100, Christophe JAILLET wrote: >>> Use 'bitmap_zalloc()' to simplify code, improve the semantic and avoid some >>> open-coded arithmetic in allocator arguments. >>> >>> Also change the corresponding 'kfree()' into 'bitmap_free()' to keep >>> consistency. >>> >>> Use 'bitmap_copy()' to avoid an explicit 'memcpy()' >>> >>> Signed-off-by: Christophe JAILLET >> >> Acked-by: Roger Pau Monné > > Oh, I see there's been further discussion on this to avoid relying > implicitly on the size of the bitmap being rounded to the size of an > unsigned long. I think a new version is expected then? > > Thanks, Roger. > Yes, I'll send a patch in order to add a 'bitmap_size()' I'll update this patch when/if it is merged. You can drop it for now. CJ