From: "Derrick, Jonathan" <jonathan.derrick@intel.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"zub@linux.fjfi.cvut.cz" <zub@linux.fjfi.cvut.cz>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"sbauer@plzdonthack.me" <sbauer@plzdonthack.me>,
"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "jonas.rabenstein@studium.uni-erlangen.de"
<jonas.rabenstein@studium.uni-erlangen.de>
Subject: Re: [PATCH 13/16] block: sed-opal: use named Opal tokens instead of integer literals
Date: Thu, 28 Mar 2019 15:44:12 +0000 [thread overview]
Message-ID: <1549586bdaaa8b72d08aa0d79b921208ad798fd4.camel@intel.com> (raw)
In-Reply-To: <1550103368-4605-14-git-send-email-zub@linux.fjfi.cvut.cz>
[-- Attachment #1: Type: text/plain, Size: 3629 bytes --]
Acked-by: Jon Derrick <jonathan.derrick@intel.com>
On Thu, 2019-02-14 at 01:16 +0100, David Kozub wrote:
> Replace integer literals by Opal tokens defined in opal_proto.h where
> possible.
>
> Signed-off-by: David Kozub <zub@linux.fjfi.cvut.cz>
> ---
> block/sed-opal.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/block/sed-opal.c b/block/sed-opal.c
> index 5395ab1c5248..be0d633783c8 100644
> --- a/block/sed-opal.c
> +++ b/block/sed-opal.c
> @@ -1180,12 +1180,12 @@ static int generic_lr_enable_disable(struct
> opal_dev *dev,
> add_token_u8(&err, dev, OPAL_STARTLIST);
>
> add_token_u8(&err, dev, OPAL_STARTNAME);
> - add_token_u8(&err, dev, 5); /* ReadLockEnabled */
> + add_token_u8(&err, dev, OPAL_READLOCKENABLED);
> add_token_u8(&err, dev, rle);
> add_token_u8(&err, dev, OPAL_ENDNAME);
>
> add_token_u8(&err, dev, OPAL_STARTNAME);
> - add_token_u8(&err, dev, 6); /* WriteLockEnabled */
> + add_token_u8(&err, dev, OPAL_WRITELOCKENABLED);
> add_token_u8(&err, dev, wle);
> add_token_u8(&err, dev, OPAL_ENDNAME);
>
> @@ -1238,22 +1238,22 @@ static int setup_locking_range(struct
> opal_dev *dev, void *data)
> add_token_u8(&err, dev, OPAL_STARTLIST);
>
> add_token_u8(&err, dev, OPAL_STARTNAME);
> - add_token_u8(&err, dev, 3); /* Ranges Start */
> + add_token_u8(&err, dev, OPAL_RANGESTART);
> add_token_u64(&err, dev, setup->range_start);
> add_token_u8(&err, dev, OPAL_ENDNAME);
>
> add_token_u8(&err, dev, OPAL_STARTNAME);
> - add_token_u8(&err, dev, 4); /* Ranges length */
> + add_token_u8(&err, dev, OPAL_RANGELENGTH);
> add_token_u64(&err, dev, setup->range_length);
> add_token_u8(&err, dev, OPAL_ENDNAME);
>
> add_token_u8(&err, dev, OPAL_STARTNAME);
> - add_token_u8(&err, dev, 5); /*ReadLockEnabled */
> + add_token_u8(&err, dev, OPAL_READLOCKENABLED);
> add_token_u64(&err, dev, !!setup->RLE);
> add_token_u8(&err, dev, OPAL_ENDNAME);
>
> add_token_u8(&err, dev, OPAL_STARTNAME);
> - add_token_u8(&err, dev, 6); /*WriteLockEnabled*/
> + add_token_u8(&err, dev, OPAL_WRITELOCKENABLED);
> add_token_u64(&err, dev, !!setup->WLE);
> add_token_u8(&err, dev, OPAL_ENDNAME);
>
> @@ -1472,7 +1472,7 @@ static int set_mbr_done(struct opal_dev *dev,
> void *data)
> add_token_u8(&err, dev, OPAL_VALUES);
> add_token_u8(&err, dev, OPAL_STARTLIST);
> add_token_u8(&err, dev, OPAL_STARTNAME);
> - add_token_u8(&err, dev, 2); /* Done */
> + add_token_u8(&err, dev, OPAL_MBRDONE);
> add_token_u8(&err, dev, *mbr_done_tf); /* Done T or F */
> add_token_u8(&err, dev, OPAL_ENDNAME);
> add_token_u8(&err, dev, OPAL_ENDLIST);
> @@ -1498,7 +1498,7 @@ static int set_mbr_enable_disable(struct
> opal_dev *dev, void *data)
> add_token_u8(&err, dev, OPAL_VALUES);
> add_token_u8(&err, dev, OPAL_STARTLIST);
> add_token_u8(&err, dev, OPAL_STARTNAME);
> - add_token_u8(&err, dev, 1);
> + add_token_u8(&err, dev, OPAL_MBRENABLE);
> add_token_u8(&err, dev, *mbr_en_dis);
> add_token_u8(&err, dev, OPAL_ENDNAME);
> add_token_u8(&err, dev, OPAL_ENDLIST);
> @@ -1523,7 +1523,7 @@ static int generic_pw_cmd(u8 *key, size_t
> key_len, u8 *cpin_uid,
> add_token_u8(&err, dev, OPAL_VALUES);
> add_token_u8(&err, dev, OPAL_STARTLIST);
> add_token_u8(&err, dev, OPAL_STARTNAME);
> - add_token_u8(&err, dev, 3); /* PIN */
> + add_token_u8(&err, dev, OPAL_PIN);
> add_token_bytestring(&err, dev, key, key_len);
> add_token_u8(&err, dev, OPAL_ENDNAME);
> add_token_u8(&err, dev, OPAL_ENDLIST);
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3278 bytes --]
next prev parent reply other threads:[~2019-03-28 15:44 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 0:15 [PATCH 00/16] sed-opal: fix shadow MBR enable/disable and clean up code David Kozub
2019-02-14 0:15 ` [PATCH 01/16] block: sed-opal: fix IOC_OPAL_ENABLE_DISABLE_MBR David Kozub
2019-03-28 17:04 ` Christoph Hellwig
2019-04-06 15:15 ` Scott Bauer
2019-02-14 0:15 ` [PATCH 02/16] block: sed-opal: fix typos and formatting David Kozub
2019-03-28 17:05 ` Christoph Hellwig
2019-02-14 0:15 ` [PATCH 03/16] block: sed-opal: use correct macro for method length David Kozub
2019-02-14 0:15 ` [PATCH 04/16] block: sed-opal: unify space check in add_token_* David Kozub
2019-03-28 15:43 ` Derrick, Jonathan
2019-03-28 17:05 ` Christoph Hellwig
2019-04-06 15:18 ` Scott Bauer
2019-04-06 15:19 ` Scott Bauer
2019-02-14 0:15 ` [PATCH 05/16] block: sed-opal: close parameter list in cmd_finalize David Kozub
2019-02-14 0:15 ` [PATCH 06/16] block: sed-opal: unify cmd start David Kozub
2019-02-14 0:15 ` [PATCH 07/16] block: sed-opal: unify error handling of responses David Kozub
2019-02-14 0:16 ` [PATCH 08/16] block: sed-opal: reuse response_get_token to decrease code duplication David Kozub
2019-02-14 0:16 ` [PATCH 09/16] block: sed-opal: print failed function address David Kozub
2019-02-14 0:16 ` [PATCH 10/16] block: sed-opal: split generation of bytestring header and content David Kozub
2019-02-14 0:16 ` [PATCH 11/16] block: sed-opal: add token for OPAL_LIFECYCLE David Kozub
2019-03-28 15:43 ` Derrick, Jonathan
2019-03-28 17:06 ` Christoph Hellwig
2019-04-06 15:19 ` Scott Bauer
2019-02-14 0:16 ` [PATCH 12/16] block: sed-opal: unify retrieval of table columns David Kozub
2019-02-14 0:16 ` [PATCH 13/16] block: sed-opal: use named Opal tokens instead of integer literals David Kozub
2019-03-28 15:44 ` Derrick, Jonathan [this message]
2019-03-28 17:06 ` Christoph Hellwig
2019-04-06 15:20 ` Scott Bauer
2019-02-14 0:16 ` [PATCH 14/16] block: sed-opal: pass steps via argument rather than via opal_dev David Kozub
2019-03-28 15:44 ` Derrick, Jonathan
2019-03-28 17:07 ` Christoph Hellwig
2019-04-06 15:20 ` Scott Bauer
2019-02-14 0:16 ` [PATCH 15/16] block: sed-opal: don't repeat opal_discovery0 in each steps array David Kozub
2019-03-28 15:44 ` Derrick, Jonathan
2019-03-28 17:09 ` Christoph Hellwig
2019-04-06 15:22 ` Scott Bauer
2019-02-14 0:16 ` [PATCH 16/16] block: sed-opal: rename next to execute_steps David Kozub
2019-04-06 15:26 ` [PATCH 00/16] sed-opal: fix shadow MBR enable/disable and clean up code Scott Bauer
2019-04-06 17:09 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1549586bdaaa8b72d08aa0d79b921208ad798fd4.camel@intel.com \
--to=jonathan.derrick@intel.com \
--cc=axboe@kernel.dk \
--cc=jonas.rabenstein@studium.uni-erlangen.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sbauer@plzdonthack.me \
--cc=zub@linux.fjfi.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).