* [PATCH] block: remove redundant unlikely annotation
@ 2019-02-12 3:16 Chengguang Xu
2019-02-12 16:31 ` Bart Van Assche
0 siblings, 1 reply; 2+ messages in thread
From: Chengguang Xu @ 2019-02-12 3:16 UTC (permalink / raw)
To: axboe; +Cc: linux-block, Chengguang Xu
unlikely has already included in IS_ERR(),
so just remove it.
Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
---
block/blk-cgroup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index 2bed5725aa03..699dba716c83 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -880,7 +880,7 @@ int blkg_conf_prep(struct blkcg *blkcg, const struct blkcg_policy *pol,
blkg_free(new_blkg);
} else {
blkg = blkg_create(pos, q, new_blkg);
- if (unlikely(IS_ERR(blkg))) {
+ if (IS_ERR(blkg)) {
ret = PTR_ERR(blkg);
goto fail_unlock;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] block: remove redundant unlikely annotation
2019-02-12 3:16 [PATCH] block: remove redundant unlikely annotation Chengguang Xu
@ 2019-02-12 16:31 ` Bart Van Assche
0 siblings, 0 replies; 2+ messages in thread
From: Bart Van Assche @ 2019-02-12 16:31 UTC (permalink / raw)
To: Chengguang Xu, axboe; +Cc: linux-block
On Tue, 2019-02-12 at 11:16 +0800, Chengguang Xu wrote:
> unlikely has already included in IS_ERR(),
> so just remove it.
>
> Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
> ---
> block/blk-cgroup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
> index 2bed5725aa03..699dba716c83 100644
> --- a/block/blk-cgroup.c
> +++ b/block/blk-cgroup.c
> @@ -880,7 +880,7 @@ int blkg_conf_prep(struct blkcg *blkcg, const struct blkcg_policy *pol,
> blkg_free(new_blkg);
> } else {
> blkg = blkg_create(pos, q, new_blkg);
> - if (unlikely(IS_ERR(blkg))) {
> + if (IS_ERR(blkg)) {
> ret = PTR_ERR(blkg);
> goto fail_unlock;
> }
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-12 16:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-12 3:16 [PATCH] block: remove redundant unlikely annotation Chengguang Xu
2019-02-12 16:31 ` Bart Van Assche
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).