From: Jens Axboe <axboe@kernel.dk>
To: John Garry <john.garry@huawei.com>
Cc: ming.lei@redhat.com, anders.roxell@linaro.org,
naresh.kamboju@linaro.org, linux-block@vger.kernel.org,
arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk-mq-sched: Don't reference queue tagset in blk_mq_sched_tags_teardown()
Date: Fri, 22 Oct 2021 09:16:24 -0600 [thread overview]
Message-ID: <163491578487.92334.5273496329606212281.b4-ty@kernel.dk> (raw)
In-Reply-To: <1634890340-15432-1-git-send-email-john.garry@huawei.com>
On Fri, 22 Oct 2021 16:12:20 +0800, John Garry wrote:
> We should not reference the queue tagset in blk_mq_sched_tags_teardown()
> (see function comment) for the blk-mq flags, so use the passed flags
> instead.
>
> This solves a use-after-free, similarly fixed earlier (and since broken
> again) in commit f0c1c4d2864e ("blk-mq: fix use-after-free in
> blk_mq_exit_sched").
>
> [...]
Applied, thanks!
[1/1] blk-mq-sched: Don't reference queue tagset in blk_mq_sched_tags_teardown()
commit: 8bdf7b3fe1f48a2c1c212d4685903bba01409c0e
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2021-10-22 15:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 8:12 [PATCH] blk-mq-sched: Don't reference queue tagset in blk_mq_sched_tags_teardown() John Garry
2021-10-22 15:16 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163491578487.92334.5273496329606212281.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=anders.roxell@linaro.org \
--cc=arnd@arndb.de \
--cc=john.garry@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=naresh.kamboju@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).