linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: geert@linux-m68k.org, linux-m68k@vger.kernel.org,
	Michael Schmitz <schmitzmic@gmail.com>
Cc: linux-block@vger.kernel.org
Subject: Re: [PATCH v1] block: ataflop: more blk-mq refactoring fixes
Date: Mon, 25 Oct 2021 07:54:56 -0600	[thread overview]
Message-ID: <163517009650.161993.17887883073883343140.b4-ty@kernel.dk> (raw)
In-Reply-To: <20211024002013.9332-1-schmitzmic@gmail.com>

On Sun, 24 Oct 2021 13:20:13 +1300, Michael Schmitz wrote:
> As it turns out, my earlier patch in commit 86d46fdaa12a (block:
> ataflop: fix breakage introduced at blk-mq refactoring) was
> incomplete. This patch fixes any remaining issues found during
> more testing and code review.
> 
> Requests exceeding 4 k are handled in 4k segments but
> __blk_mq_end_request() is never called on these (still
> sectors outstanding on the request). With redo_fd_request()
> removed, there is no provision to kick off processing of the
> next segment, causing requests exceeding 4k to hang. (By
> setting /sys/block/fd0/queue/max_sectors_k <= 4 as workaround,
> this behaviour can be avoided).
> 
> [...]

Applied, thanks!

[1/1] block: ataflop: more blk-mq refactoring fixes
      commit: d28e4dff085c5a87025c9a0a85fb798bd8e9ca17

Best regards,
-- 
Jens Axboe



      reply	other threads:[~2021-10-25 13:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-24  0:20 [PATCH v1] block: ataflop: more blk-mq refactoring fixes Michael Schmitz
2021-10-25 13:54 ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=163517009650.161993.17887883073883343140.b4-ty@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=geert@linux-m68k.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=schmitzmic@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).