From: Jens Axboe <axboe@kernel.dk>
To: tj@kernel.org, Yu Kuai <yukuai1@huaweicloud.com>
Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-block@vger.kernel.org, yi.zhang@huawei.com,
yukuai3@huawei.com
Subject: Re: [PATCH 0/2] blk-throttle: improve bypassing bios checkings
Date: Sat, 24 Sep 2022 09:00:10 -0600 [thread overview]
Message-ID: <166403161084.5171.274436515046613194.b4-ty@kernel.dk> (raw)
In-Reply-To: <20220921095309.1481289-1-yukuai1@huaweicloud.com>
On Wed, 21 Sep 2022 17:53:07 +0800, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
>
> Currently, "tg->has_rules" and "tg->flags & THROTL_TG_HAS_IOPS_LIMIT"
> both try to bypass bios that don't need to be throttled, however, they are
> a little redundant and both not perfect:
>
> 1) "tg->has_rules" only distinguish read and write, but not iops and bps
> limit.
> 2) "tg->flags & THROTL_TG_HAS_IOPS_LIMIT" only check if iops limit
> exist, read and write is not distinguished, and bps limit is not
> checked.
>
> [...]
Applied, thanks!
[1/2] blk-throttle: remove THROTL_TG_HAS_IOPS_LIMIT
commit: 85496749904016f36b69332f73a1cf3ecfee828f
[2/2] blk-throttle: improve bypassing bios checkings
commit: 81c7a63abc7c0be572b4f853e913ce93a34f6e1b
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2022-09-24 15:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 9:53 [PATCH 0/2] blk-throttle: improve bypassing bios checkings Yu Kuai
2022-09-21 9:53 ` [PATCH 1/2] blk-throttle: remove THROTL_TG_HAS_IOPS_LIMIT Yu Kuai
2022-09-24 3:31 ` Tejun Heo
2022-09-21 9:53 ` [PATCH 2/2] blk-throttle: improve bypassing bios checkings Yu Kuai
2022-09-24 3:32 ` Tejun Heo
2022-09-24 15:00 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166403161084.5171.274436515046613194.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).