From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7972C49EA6 for ; Sat, 26 Jun 2021 08:52:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81CD261923 for ; Sat, 26 Jun 2021 08:52:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229586AbhFZIyX (ORCPT ); Sat, 26 Jun 2021 04:54:23 -0400 Received: from luna.lichtvoll.de ([194.150.191.11]:48027 "EHLO mail.lichtvoll.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229518AbhFZIyX (ORCPT ); Sat, 26 Jun 2021 04:54:23 -0400 Received: from ananda.localnet (unknown [IPv6:2001:a62:1a52:5a00:19da:1263:b56c:4c4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.lichtvoll.de (Postfix) with ESMTPSA id 2675027AF85; Sat, 26 Jun 2021 10:52:00 +0200 (CEST) From: Martin Steigerwald To: NeilBrown Cc: linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: Assumption on fixed device numbers in Plasma's desktop search Baloo Date: Sat, 26 Jun 2021 10:51:59 +0200 Message-ID: <1769070.0rzTUBzp5V@ananda> In-Reply-To: <162466884942.28671.6997551060359774034@noble.neil.brown.name> References: <41661070.mPYKQbcTYQ@ananda> <162466884942.28671.6997551060359774034@noble.neil.brown.name> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Authentication-Results: mail.lichtvoll.de; auth=pass smtp.auth=martin2 smtp.mailfrom=martin@lichtvoll.de Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org NeilBrown - 26.06.21, 02:54:09 CEST: > > And that Baloo needs an "invariant" for > > > a file. See comment #11 of that bug report: > That is really hard to provide in general. Possibly the best approach > is to use the statfs() systemcall to get the "f_fsid" field. This is > 64bits. It is not supported uniformly well by all filesystems, but I > think it is at least not worse than using the device number. For a > lot of older filesystems it is just an encoding of the device number. > > For btrfs, xfs, ext4 it is much much better. Thank you for the clear statement and for your alternative suggestion. I will forward this to Baloo upstream. I think the main focus of Baloo would be to work on currently mostly in use Linux filesystem which should be BTRFS, XFS, EXT4 and probably F2FS. -- Martin