Re: [PATCH 07/14] bcache: bch_nvm_free_pages() of the buddy

[Coly Li <colyli@suse.de>]

On 6/22/21 6:53 PM, Hannes Reinecke wrote:
> On 6/15/21 7:49 AM, Coly Li wrote:
>> From: Jianpeng Ma <jianpeng.ma@intel.com>
>>
>> This patch implements the bch_nvm_free_pages() of the buddy.
>>
>> The difference between this and page-buddy-free:
>> it need owner_uuid to free owner allocated pages.And must
>> persistent after free.
>>
>> Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
>> Co-developed-by: Qiaowei Ren <qiaowei.ren@intel.com>
>> Signed-off-by: Qiaowei Ren <qiaowei.ren@intel.com>
>> Signed-off-by: Coly Li <colyli@suse.de>
>> ---
>>  drivers/md/bcache/nvm-pages.c | 164 ++++++++++++++++++++++++++++++++--
>>  drivers/md/bcache/nvm-pages.h |   3 +-
>>  2 files changed, 159 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/md/bcache/nvm-pages.c b/drivers/md/bcache/nvm-pages.c
>> index 5d095d241483..74d08950c67c 100644
>> --- a/drivers/md/bcache/nvm-pages.c
>> +++ b/drivers/md/bcache/nvm-pages.c
>> @@ -52,7 +52,7 @@ static void release_nvm_set(struct bch_nvm_set *nvm_set)
>>  	kfree(nvm_set);
>>  }
>>  
>> -static struct page *nvm_vaddr_to_page(struct bch_nvm_namespace *ns, void *addr)
>> +static struct page *nvm_vaddr_to_page(void *addr)
>>  {
>>  	return virt_to_page(addr);
>>  }
> If you don't need this argument please modify the patch adding the
> nvm_vaddr_to_page() function.

Copied. We will add the patch where  nvm_vaddr_to_page() was firstly
added in.

It will be updated in next post.

Thanks for your review.

Coly Li


[snipped]