From: Max Gurtovoy <mgurtovoy@nvidia.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: <hch@infradead.org>, <virtualization@lists.linux-foundation.org>,
<kvm@vger.kernel.org>, <stefanha@redhat.com>,
<israelr@nvidia.com>, <nitzanc@nvidia.com>, <oren@nvidia.com>,
<linux-block@vger.kernel.org>, <axboe@kernel.dk>
Subject: Re: [PATCH v3 1/1] virtio-blk: add num_request_queues module parameter
Date: Sun, 24 Oct 2021 10:19:51 +0300 [thread overview]
Message-ID: <19cbe00a-409c-fd4b-4466-6b9fe650229f@nvidia.com> (raw)
In-Reply-To: <20211022052950-mutt-send-email-mst@kernel.org>
On 10/22/2021 12:30 PM, Michael S. Tsirkin wrote:
> On Thu, Sep 02, 2021 at 11:46:22PM +0300, Max Gurtovoy wrote:
>> Sometimes a user would like to control the amount of request queues to
>> be created for a block device. For example, for limiting the memory
>> footprint of virtio-blk devices.
>>
>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
>> ---
>>
>> changes from v2:
>> - renamed num_io_queues to num_request_queues (from Stefan)
>> - added Reviewed-by signatures (from Stefan and Christoph)
>>
>> changes from v1:
>> - use param_set_uint_minmax (from Christoph)
>> - added "Should > 0" to module description
>>
>> Note: This commit apply on top of Jens's branch for-5.15/drivers
>>
>> ---
>> drivers/block/virtio_blk.c | 21 ++++++++++++++++++++-
>> 1 file changed, 20 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
>> index 4b49df2dfd23..aaa2833a4734 100644
>> --- a/drivers/block/virtio_blk.c
>> +++ b/drivers/block/virtio_blk.c
>> @@ -24,6 +24,23 @@
>> /* The maximum number of sg elements that fit into a virtqueue */
>> #define VIRTIO_BLK_MAX_SG_ELEMS 32768
>>
>> +static int virtblk_queue_count_set(const char *val,
>> + const struct kernel_param *kp)
>> +{
>> + return param_set_uint_minmax(val, kp, 1, nr_cpu_ids);
>> +}
>> +
>> +static const struct kernel_param_ops queue_count_ops = {
>> + .set = virtblk_queue_count_set,
>> + .get = param_get_uint,
>> +};
>> +
>> +static unsigned int num_request_queues;
>> +module_param_cb(num_request_queues, &queue_count_ops, &num_request_queues,
>> + 0644);
>> +MODULE_PARM_DESC(num_request_queues,
>> + "Number of request queues to use for blk device. Should > 0");
>> +
>> static int major;
>> static DEFINE_IDA(vd_index_ida);
>>
> I wasn't happy with the message here so I tweaked it.
>
> Please look at it in linux-next and confirm. Thanks!
Looks good.
>
>
>> @@ -501,7 +518,9 @@ static int init_vq(struct virtio_blk *vblk)
>> if (err)
>> num_vqs = 1;
>>
>> - num_vqs = min_t(unsigned int, nr_cpu_ids, num_vqs);
>> + num_vqs = min_t(unsigned int,
>> + min_not_zero(num_request_queues, nr_cpu_ids),
>> + num_vqs);
>>
>> vblk->vqs = kmalloc_array(num_vqs, sizeof(*vblk->vqs), GFP_KERNEL);
>> if (!vblk->vqs)
>> --
>> 2.18.1
next prev parent reply other threads:[~2021-10-24 7:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 20:46 [PATCH v3 1/1] virtio-blk: add num_request_queues module parameter Max Gurtovoy
2021-09-03 6:06 ` Pankaj Gupta
2021-09-05 7:46 ` Leon Romanovsky
2021-09-05 8:49 ` Chaitanya Kulkarni
2021-09-05 9:19 ` Max Gurtovoy
2021-09-05 10:19 ` Leon Romanovsky
2021-09-05 11:16 ` Max Gurtovoy
2021-09-05 13:10 ` Leon Romanovsky
2021-09-05 13:16 ` Max Gurtovoy
2021-09-05 10:20 ` Leon Romanovsky
2021-09-05 15:15 ` Michael S. Tsirkin
2021-09-07 23:04 ` Leon Romanovsky
2021-10-22 9:30 ` Michael S. Tsirkin
2021-10-24 7:19 ` Max Gurtovoy [this message]
2021-10-24 8:12 ` Max Gurtovoy
2021-10-24 8:48 ` Michael S. Tsirkin
2021-10-24 10:57 ` Max Gurtovoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19cbe00a-409c-fd4b-4466-6b9fe650229f@nvidia.com \
--to=mgurtovoy@nvidia.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=israelr@nvidia.com \
--cc=kvm@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=mst@redhat.com \
--cc=nitzanc@nvidia.com \
--cc=oren@nvidia.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).