From: Sagi Grimberg <sagi@grimberg.me>
To: Yi Zhang <yi.zhang@redhat.com>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
Omar Sandoval <osandov@osandov.com>
Cc: Keith Busch <kbusch@kernel.org>,
Bart Van Assche <bvanassche@acm.org>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v4 7/7] nvme: support rdma transport type
Date: Fri, 14 Aug 2020 13:45:18 -0700 [thread overview]
Message-ID: <1d211ba1-c791-54b8-6811-b159a8a2868b@grimberg.me> (raw)
In-Reply-To: <af7154de-f2bb-fde6-4c6c-243711f971cb@redhat.com>
>>> @@ -124,6 +134,11 @@ _setup_nvmet() {
>>> modprobe nvmet-${nvme_trtype}
>>> fi
>>> modprobe nvme-${nvme_trtype}
>>> + if [[ "${nvme_trtype}" == "rdma" ]]; then
>>> + start_soft_rdma
>>> + rdma_intfs=$(rdma_network_interfaces)
>>> + def_traddr=$(get_ipv4_addr ${rdma_intfs[0]})
> The first rdma_intfs here maybe have DOWN state, which doesn't have an
> addr[1], I found similar check code here[2]
> [1]
> # echo $rdma_intfs
> rdma_intfs:eno1
> eno2
> eno3
> eno4
> eno49
> eno50
> # [root@hpe-dl380gen9-01 blktests]# ip a s
> 1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN
> group default qlen 1000
> link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
> inet 127.0.0.1/8 scope host lo
> valid_lft forever preferred_lft forever
> inet6 ::1/128 scope host
> valid_lft forever preferred_lft forever
> 2: eno1: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc mq state
> DOWN group default qlen 1000
> link/ether 3c:a8:2a:21:7d:a4 brd ff:ff:ff:ff:ff:ff
> 3: eno49: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP
> group default qlen 1000
> link/ether 8c:dc:d4:1e:7a:78 brd ff:ff:ff:ff:ff:ff
> inet 10.16.203.27/24 brd 10.16.203.255 scope global dynamic
> noprefixroute eno49
> valid_lft 84814sec preferred_lft 84814sec
> inet6 2620:52:0:10cb:8edc:d4ff:fe1e:7a78/64 scope global dynamic
> noprefixroute
> valid_lft 2591978sec preferred_lft 604778sec
> inet6 fe80::8edc:d4ff:fe1e:7a78/64 scope link noprefixroute
> valid_lft forever preferred_lft forever
> [2]
> # grep -rin rdma_network_ tests/nvmeof-mp/
> tests/nvmeof-mp/rc:93: for i in $(rdma_network_interfaces); do
> tests/nvmeof-mp/rc:235: ) && for i in $(rdma_network_interfaces); do
This is annoying, I wish it would just work on the lo interface but it
doesn't for some reason...
next prev parent reply other threads:[~2020-08-14 20:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 6:18 [PATCH v4 0/7] blktests: Add support to run nvme tests with tcp/rdma transports Sagi Grimberg
2020-08-14 6:18 ` [PATCH v4 1/7] nvme: consolidate nvme requirements based on transport type Sagi Grimberg
2020-08-14 6:18 ` [PATCH v4 2/7] nvme: consolidate some nvme-cli utility functions Sagi Grimberg
2020-08-14 16:12 ` Logan Gunthorpe
2020-08-14 6:18 ` [PATCH v4 3/7] nvme: make tests transport type agnostic Sagi Grimberg
2020-08-14 16:24 ` Logan Gunthorpe
2020-08-14 6:18 ` [PATCH v4 4/7] tests/nvme: restrict tests to specific transports Sagi Grimberg
2020-08-14 6:18 ` [PATCH v4 5/7] nvme: support nvme-tcp when runinng tests Sagi Grimberg
2020-08-14 6:18 ` [PATCH v4 6/7] common: move module_unload to common Sagi Grimberg
2020-08-14 6:18 ` [PATCH v4 7/7] nvme: support rdma transport type Sagi Grimberg
2020-08-14 10:49 ` Yi Zhang
2020-08-14 15:45 ` Yi Zhang
2020-08-14 20:45 ` Sagi Grimberg [this message]
2020-08-14 20:44 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d211ba1-c791-54b8-6811-b159a8a2868b@grimberg.me \
--to=sagi@grimberg.me \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=osandov@osandov.com \
--cc=yi.zhang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).